You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/13 03:45:12 UTC
[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #19117: [1.x] Backport #19103
samskalicky commented on a change in pull request #19117:
URL: https://github.com/apache/incubator-mxnet/pull/19117#discussion_r487476601
##########
File path: include/mxnet/lib_api.h
##########
@@ -732,6 +732,9 @@ typedef MXReturnValue (*mutateInputs_t)(const std::unordered_map<std::string,
std::vector<int>* input_indices);
typedef MXReturnValue (*createOpState_t)(const std::unordered_map<std::string,
std::string>& attributes,
+ const MXContext& ctx,
+ const std::vector<std::vector<unsigned int> >& in_shapes,
+ const std::vector<int> in_types,
Review comment:
Hi @szha, youre right. The Extensions API is not backwards compatible. Every change increments the version number:
https://github.com/apache/incubator-mxnet/blob/f1acda73e0b2ca5f1b6ff89f25c17a838819be82/include/mxnet/lib_api.h#L56
And the version number is required to match:
https://github.com/apache/incubator-mxnet/blob/f1acda73e0b2ca5f1b6ff89f25c17a838819be82/src/c_api/c_api.cc#L1500-L1503
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org