You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/12/08 01:24:37 UTC
Review Request 54516: Removed the TODO in
AgentAPITest.AttachContainerOutputFailure test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54516/
-----------------------------------------------------------
Review request for mesos and Anand Mazumdar.
Repository: mesos
Description
-------
This test is still valuable to test the case when a containerizer
does not support `attach`, e.g., DockerContainerizer.
Diffs
-----
src/tests/api_tests.cpp 4bc2c746162b937cc1bdb886963b7835bf581c61
Diff: https://reviews.apache.org/r/54516/diff/
Testing
-------
Thanks,
Vinod Kone
Re: Review Request 54516: Removed the TODO in
AgentAPITest.AttachContainerOutputFailure test.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54516/
-----------------------------------------------------------
(Updated Dec. 12, 2016, 12:34 a.m.)
Review request for mesos and Anand Mazumdar.
Changes
-------
rebased. NNFR.
Repository: mesos
Description
-------
This test is still valuable to test the case when a containerizer
does not support `attach`, e.g., DockerContainerizer.
Diffs (updated)
-----
src/tests/api_tests.cpp 098804881c34acf53a43e332caa677c288bf8b06
Diff: https://reviews.apache.org/r/54516/diff/
Testing
-------
Thanks,
Vinod Kone
Re: Review Request 54516: Removed the TODO in
AgentAPITest.AttachContainerOutputFailure test.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54516/#review158765
-----------------------------------------------------------
Ship it!
Ship It!
- Anand Mazumdar
On Dec. 8, 2016, 9:52 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54516/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2016, 9:52 p.m.)
>
>
> Review request for mesos and Anand Mazumdar.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test is still valuable to test the case when a containerizer
> does not support `attach`, e.g., DockerContainerizer.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 4bc2c746162b937cc1bdb886963b7835bf581c61
>
> Diff: https://reviews.apache.org/r/54516/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 54516: Removed the TODO in
AgentAPITest.AttachContainerOutputFailure test.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54516/
-----------------------------------------------------------
(Updated Dec. 8, 2016, 9:52 p.m.)
Review request for mesos and Anand Mazumdar.
Changes
-------
rebased.
Repository: mesos
Description
-------
This test is still valuable to test the case when a containerizer
does not support `attach`, e.g., DockerContainerizer.
Diffs (updated)
-----
src/tests/api_tests.cpp 4bc2c746162b937cc1bdb886963b7835bf581c61
Diff: https://reviews.apache.org/r/54516/diff/
Testing
-------
Thanks,
Vinod Kone