[jira] [Updated] (OAK-3546) Improve ObservationManagerImpl timeout message

["Alex Parvulescu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Parvulescu updated OAK-3546:
---------------------------------
    Attachment: OAK-3546.patch

proposed patch. [~mduerig] could you take a look?
patch changes:
 - had to add the listenerId, so that it can be exposed via the toString method
- 'filterProvider' doesn't have a useful toString impl, not sure if it makes sense to add one as part of this Jira.
- warn message will look like:
{code}
ChangeProcessor [listenerId=1, tracker=///*[1111111b]@org.apache.jackrabbit.oak.jcr.observation.ObservationTest$12, contentSession=session-8, filterProvider=org.apache.jackrabbit.oak.plugins.observation.filter.FilterBuilder$1@3c70cf37, eventCount=0, eventDuration=0, commitRateLimiter=null, running=true]
{code}

> Improve ObservationManagerImpl timeout message
> ----------------------------------------------
>
>                 Key: OAK-3546
>                 URL: https://issues.apache.org/jira/browse/OAK-3546
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: jcr
>            Reporter: Alex Parvulescu
>            Priority: Minor
>         Attachments: OAK-3546.patch
>
>
> ObservationManagerImpl in its current impl will try to stop a given change processor with a timeout. if this timeout expires a warning message is logged but it's not too clear on who is the component not behaving nicely:
> {code}
> *WARN* [FelixStartLevel] org.apache.jackrabbit.oak.jcr.observation.ObservationManagerImpl Timed out waiting for change processor to stop after 1000 milliseconds. Falling back to asynchronous stop.
> {code}
> I'd like the message to include more identifiable information. 
> fyi [~mduerig] 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)