You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/08/09 02:44:47 UTC

[GitHub] [rocketmq] vongosling commented on a change in pull request #1352: [RIP-15]Add Ipv6 support for RocketMQ

vongosling commented on a change in pull request #1352: [RIP-15]Add Ipv6 support for RocketMQ
URL: https://github.com/apache/rocketmq/pull/1352#discussion_r312312100
 
 

 ##########
 File path: store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java
 ##########
 @@ -263,7 +270,7 @@ public void should_return_zero_when_consume_queue_not_found() throws Interrupted
     }
 
     @Test
-    public void should_return_negative_one_when_invoke_getMessageStoreTimeStamp_if_consume_queue_not_found() throws InterruptedException {
+    public void should_return_negative_one_when_invoke_getMessageStoreTimeStamp_if_consume_queue_not_found() throws InterruptedException, UnknownHostException {
 
 Review comment:
   Can you modify the test method signature of this section according to code style(test[method]_[conditon] ) in Apache RocketMQ ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services