You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "1996fanrui (via GitHub)" <gi...@apache.org> on 2023/08/02 03:54:39 UTC

[GitHub] [flink] 1996fanrui opened a new pull request, #23119: [FLINK-32663][checkpoint] Fix the bug that checkpoint should not be triggered after all tasks have received end-of-data when checkpoint is disabled

1996fanrui opened a new pull request, #23119:
URL: https://github.com/apache/flink/pull/23119

   ## What is the purpose of the change
   
   Fix the bug that checkpoint should not be triggered after all tasks have received end-of-data when checkpoint is disabled.
   
   
   ## Brief change log
   
   - [FLINK-32663][checkpoint] Fix the bug that checkpoint should not be triggered after all tasks have received end-of-data when checkpoint is disabled
   - [FLINK-32663][checkpoint] Fix the bug that checkpoint should not be triggered after all tasks have received end-of-data when checkpoint is disabled
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature?  no
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #23119: [FLINK-32663][checkpoint] Fix the bug that checkpoint should not be triggered after all tasks have received end-of-data when checkpoint is disabled

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23119:
URL: https://github.com/apache/flink/pull/23119#issuecomment-1661453151

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ca6d610b3ea26671ac62115acf1a186ffd2d42c6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ca6d610b3ea26671ac62115acf1a186ffd2d42c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ca6d610b3ea26671ac62115acf1a186ffd2d42c6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] lindong28 merged pull request #23119: [FLINK-32663][checkpoint] Fix the bug that checkpoint should not be triggered after all tasks have received end-of-data when checkpoint is disabled

Posted by "lindong28 (via GitHub)" <gi...@apache.org>.
lindong28 merged PR #23119:
URL: https://github.com/apache/flink/pull/23119


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] lindong28 commented on pull request #23119: [FLINK-32663][checkpoint] Fix the bug that checkpoint should not be triggered after all tasks have received end-of-data when checkpoint is disabled

Posted by "lindong28 (via GitHub)" <gi...@apache.org>.
lindong28 commented on PR #23119:
URL: https://github.com/apache/flink/pull/23119#issuecomment-1661514057

   Thanks for the PR! LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #23119: [FLINK-32663][checkpoint] Fix the bug that checkpoint should not be triggered after all tasks have received end-of-data when checkpoint is disabled

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #23119:
URL: https://github.com/apache/flink/pull/23119#issuecomment-1661540796

   Thanks @lindong28 for the quick review and merge!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #23119: [FLINK-32663][checkpoint] Fix the bug that checkpoint should not be triggered after all tasks have received end-of-data when checkpoint is disabled

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #23119:
URL: https://github.com/apache/flink/pull/23119#issuecomment-1661496280

   cc @lindong28 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org