You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "SadiJr (via GitHub)" <gi...@apache.org> on 2023/08/18 18:35:52 UTC

[GitHub] [cloudstack] SadiJr commented on a diff in pull request #7214: Improve logs when adding components to avoid set

SadiJr commented on code in PR #7214:
URL: https://github.com/apache/cloudstack/pull/7214#discussion_r1298747382


##########
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java:
##########
@@ -1058,10 +1061,7 @@ public void orchestrateStart(final String vmUuid, final Map<VirtualMachineProfil
 
         DataCenterDeployment plan = new DataCenterDeployment(vm.getDataCenterId(), vm.getPodIdToDeployIn(), null, null, null, null, ctx);
         if (planToDeploy != null && planToDeploy.getDataCenterId() != 0) {
-            if (s_logger.isDebugEnabled()) {
-                s_logger.debug("advanceStart: DeploymentPlan is provided, using dcId:" + planToDeploy.getDataCenterId() + ", podId: " + planToDeploy.getPodId() +
-                        ", clusterId: " + planToDeploy.getClusterId() + ", hostId: " + planToDeploy.getHostId() + ", poolId: " + planToDeploy.getPoolId());
-            }
+            s_logger.debug(DeploymentPlanningManagerImpl.logDeploymentWithoutException((VirtualMachine) vm, planToDeploy, planToDeploy.getAvoids(), (DeploymentPlanner) plan));

Review Comment:
   Done, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org