You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/04 19:08:22 UTC

[GitHub] [cloudstack] GabrielBrascher commented on pull request #4220: Fix cpuallocated value in findHostsForMIgration api

GabrielBrascher commented on pull request #4220:
URL: https://github.com/apache/cloudstack/pull/4220#issuecomment-668773172


   @DaanHoogland @ravening I am good with the code as it is, I just saw that maybe the method could be also used in the other context considering how similar those lines are.
   
   Note that even `DecimalFormat decimalFormat = new DecimalFormat("#.##");` is duplicated and used on the same way for `cpuAllocated` and `memoryAllocated`. However I don't want to stall this PR with that observation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org