You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opennlp.apache.org by ko...@apache.org on 2017/04/24 01:56:46 UTC
opennlp git commit: OPENNLP-1039: PerceptronTrainer should call
super.isValid() in its isValid(). This closes apache/opennlp#177
Repository: opennlp
Updated Branches:
refs/heads/master 3a22156fa -> 735b1b598
OPENNLP-1039: PerceptronTrainer should call super.isValid() in its isValid(). This closes apache/opennlp#177
Project: http://git-wip-us.apache.org/repos/asf/opennlp/repo
Commit: http://git-wip-us.apache.org/repos/asf/opennlp/commit/735b1b59
Tree: http://git-wip-us.apache.org/repos/asf/opennlp/tree/735b1b59
Diff: http://git-wip-us.apache.org/repos/asf/opennlp/diff/735b1b59
Branch: refs/heads/master
Commit: 735b1b59862dc1b5f7e60549aa7c33dbcc4095b2
Parents: 3a22156
Author: koji <ko...@apache.org>
Authored: Mon Apr 24 09:56:08 2017 +0800
Committer: koji <ko...@apache.org>
Committed: Mon Apr 24 09:56:08 2017 +0800
----------------------------------------------------------------------
.../opennlp/tools/ml/perceptron/PerceptronTrainer.java | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/opennlp/blob/735b1b59/opennlp-tools/src/main/java/opennlp/tools/ml/perceptron/PerceptronTrainer.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/ml/perceptron/PerceptronTrainer.java b/opennlp-tools/src/main/java/opennlp/tools/ml/perceptron/PerceptronTrainer.java
index dec6274..129c576 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/ml/perceptron/PerceptronTrainer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/ml/perceptron/PerceptronTrainer.java
@@ -86,8 +86,17 @@ public class PerceptronTrainer extends AbstractEventTrainer {
}
public boolean isValid() {
+ if (!super.isValid()) {
+ return false;
+ }
+
String algorithmName = getAlgorithm();
- return !(algorithmName != null && !(PERCEPTRON_VALUE.equals(algorithmName)));
+ if (algorithmName != null) {
+ return PERCEPTRON_VALUE.equals(algorithmName);
+ }
+ else {
+ return true;
+ }
}
public boolean isSortAndMerge() {