You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "yugushihuang (via GitHub)" <gi...@apache.org> on 2023/11/20 23:13:20 UTC
[PR] Improve set deletions percentage javadoc [lucene]
yugushihuang opened a new pull request, #12828:
URL: https://github.com/apache/lucene/pull/12828
As a follow item of Discussion [issue](https://github.com/apache/lucene/issues/12792), improve the java doc to make the formula of deletion percentage clear to developers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Improve set deletions percentage javadoc [lucene]
Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz commented on PR #12828:
URL: https://github.com/apache/lucene/pull/12828#issuecomment-1961638266
It looks like this PR is in a bad state somehow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Improve set deletions percentage javadoc [lucene]
Posted by "yugushihuang (via GitHub)" <gi...@apache.org>.
yugushihuang commented on code in PR #12828:
URL: https://github.com/apache/lucene/pull/12828#discussion_r1404662302
##########
lucene/core/src/java/org/apache/lucene/index/TieredMergePolicy.java:
##########
@@ -150,9 +150,10 @@ public double getMaxMergedSegmentMB() {
}
/**
- * Controls the maximum percentage of deleted documents that is tolerated in the index. Lower
- * values make the index more space efficient at the expense of increased CPU and I/O activity.
- * Values must be between 5 and 50. Default value is 20.
+ * Sets the maximum percentage of deleted documents that is tolerated in the index. The
Review Comment:
Thanks for the review, I will modify the wording.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Improve set deletions percentage javadoc [lucene]
Posted by "shubhamvishu (via GitHub)" <gi...@apache.org>.
shubhamvishu commented on code in PR #12828:
URL: https://github.com/apache/lucene/pull/12828#discussion_r1400152449
##########
lucene/core/src/java/org/apache/lucene/index/TieredMergePolicy.java:
##########
@@ -150,9 +150,10 @@ public double getMaxMergedSegmentMB() {
}
/**
- * Controls the maximum percentage of deleted documents that is tolerated in the index. Lower
- * values make the index more space efficient at the expense of increased CPU and I/O activity.
- * Values must be between 5 and 50. Default value is 20.
+ * Sets the maximum percentage of deleted documents that is tolerated in the index. The
Review Comment:
Maybe it'll be great if we include what @jpountz defined it on the issue here as well since it was easier to understand...."how much of my doc ID space is taken by deleted docs" -> "percentage of doc id space taken by deleted docs". WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Improve set deletions percentage javadoc [lucene]
Posted by "yugushihuang (via GitHub)" <gi...@apache.org>.
yugushihuang commented on PR #12828:
URL: https://github.com/apache/lucene/pull/12828#issuecomment-2584906452
@jpountz I have sync the fork. @shubhamvishu has already approved the commit. I will merge once the check passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Improve set deletions percentage javadoc [lucene]
Posted by "yugushihuang (via GitHub)" <gi...@apache.org>.
yugushihuang commented on PR #12828:
URL: https://github.com/apache/lucene/pull/12828#issuecomment-2606429556
@jpountz It looks like I do not have push access to the repo. Can you help me merge it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Improve set deletions percentage javadoc [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on PR #12828:
URL: https://github.com/apache/lucene/pull/12828#issuecomment-3200783770
I saw we hadn't backported to 10x, but I think it makes sense to. It's done now ([commit](https://github.com/apache/lucene/commit/57ae79a34b2cf7ce9fc2533784406e6d83d44b31)), which allowed me to backport #14893 without conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Improve set deletions percentage javadoc [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12828:
URL: https://github.com/apache/lucene/pull/12828#issuecomment-1880899727
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Improve set deletions percentage javadoc [lucene]
Posted by "msokolov (via GitHub)" <gi...@apache.org>.
msokolov merged PR #12828:
URL: https://github.com/apache/lucene/pull/12828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Improve set deletions percentage javadoc [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12828:
URL: https://github.com/apache/lucene/pull/12828#issuecomment-1986591236
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Improve set deletions percentage javadoc [lucene]
Posted by "shubhamvishu (via GitHub)" <gi...@apache.org>.
shubhamvishu commented on code in PR #12828:
URL: https://github.com/apache/lucene/pull/12828#discussion_r1400152449
##########
lucene/core/src/java/org/apache/lucene/index/TieredMergePolicy.java:
##########
@@ -150,9 +150,10 @@ public double getMaxMergedSegmentMB() {
}
/**
- * Controls the maximum percentage of deleted documents that is tolerated in the index. Lower
- * values make the index more space efficient at the expense of increased CPU and I/O activity.
- * Values must be between 5 and 50. Default value is 20.
+ * Sets the maximum percentage of deleted documents that is tolerated in the index. The
Review Comment:
Maybe it'll be great if we include what @jpountz defined it on the issue here as well...."how much of my doc ID space is taken by deleted docs" -> "percentage of doc id space taken by deleted docs". WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org