You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by chenliang613 <gi...@git.apache.org> on 2018/06/20 12:22:03 UTC

[GitHub] carbondata pull request #2265: Added Performance Optimization for Presto by ...

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2265#discussion_r196753301
  
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataMetadata.java ---
    @@ -152,19 +176,20 @@ private ConnectorTableMetadata getTableMetadata(SchemaTableName schemaTableName)
     
           Type spiType = carbonDataType2SpiMapper(cs);
           columnHandles.put(cs.getColumnName(),
    -          new CarbondataColumnHandle(connectorId, cs.getColumnName(), spiType, column.getSchemaOrdinal(),
    -              column.getKeyOrdinal(), column.getColumnGroupOrdinal(), false, cs.getColumnGroupId(),
    -              cs.getColumnUniqueId(), cs.isUseInvertedIndex(), cs.getPrecision(), cs.getScale()));
    +          new CarbondataColumnHandle(connectorId, cs.getColumnName(), spiType,
    +              column.getSchemaOrdinal(), column.getKeyOrdinal(), column.getColumnGroupOrdinal(),
    +              false, cs.getColumnGroupId(), cs.getColumnUniqueId(), cs.isUseInvertedIndex(),
    +              cs.getPrecision(), cs.getScale()));
         }
     
         for (CarbonMeasure measure : cb.getMeasureByTableName(tableName)) {
           ColumnSchema cs = measure.getColumnSchema();
    -
           Type spiType = carbonDataType2SpiMapper(cs);
           columnHandles.put(cs.getColumnName(),
    -          new CarbondataColumnHandle(connectorId, cs.getColumnName(), spiType, cs.getSchemaOrdinal(),
    -              measure.getOrdinal(), cs.getColumnGroupId(), true, cs.getColumnGroupId(),
    -              cs.getColumnUniqueId(), cs.isUseInvertedIndex(), cs.getPrecision(), cs.getScale()));
    +          new CarbondataColumnHandle(connectorId, cs.getColumnName(), spiType,
    +              cs.getSchemaOrdinal(), measure.getOrdinal(), cs.getColumnGroupId(), true,
    +              cs.getColumnGroupId(), cs.getColumnUniqueId(), cs.isUseInvertedIndex(),
    +              cs.getPrecision(), cs.getScale()));
         }
     
         //should i cache it?
    --- End diff --
    
    this comment, suggest optimizing it.


---