You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/04/28 23:03:18 UTC
[GitHub] [trafficserver] randall opened a new pull request #6717: Fixup .gitignores to match repo reality
randall opened a new pull request #6717:
URL: https://github.com/apache/trafficserver/pull/6717
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on a change in pull request #6717: Fixup .gitignores to match repo reality
Posted by GitBox <gi...@apache.org>.
randall commented on a change in pull request #6717:
URL: https://github.com/apache/trafficserver/pull/6717#discussion_r417643355
##########
File path: .gitignore
##########
@@ -43,7 +43,7 @@ Makefile-pl
config.cache
config.status
config.nice
-config.h
+/config.h
Review comment:
you're right! We don't. Removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #6717: Fixup .gitignores to match repo reality
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #6717:
URL: https://github.com/apache/trafficserver/pull/6717#issuecomment-621279430
[approve ci fedora]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on a change in pull request #6717: Fixup .gitignores to match repo reality
Posted by GitBox <gi...@apache.org>.
maskit commented on a change in pull request #6717:
URL: https://github.com/apache/trafficserver/pull/6717#discussion_r417009831
##########
File path: .gitignore
##########
@@ -43,7 +43,7 @@ Makefile-pl
config.cache
config.status
config.nice
-config.h
+/config.h
Review comment:
Do we need this line? I don't have this file on my Mac and Ubuntu.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #6717: Fixup .gitignores to match repo reality
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #6717:
URL: https://github.com/apache/trafficserver/pull/6717#issuecomment-623849544
Cherry-picked to v9.0.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall removed a comment on pull request #6717: Fixup .gitignores to match repo reality
Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #6717:
URL: https://github.com/apache/trafficserver/pull/6717#issuecomment-621279430
[approve ci fedora]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org