You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/03/18 07:45:54 UTC

[GitHub] [pulsar] Anonymitaet edited a comment on pull request #9951: [Doc] Support DLQ in key_shared subscription mode

Anonymitaet edited a comment on pull request #9951:
URL: https://github.com/apache/pulsar/pull/9951#issuecomment-801697860


   Hi @codelipenghui based on your comment [here](https://github.com/apache/pulsar/pull/9583#issuecomment-783424273), should we update the docs as below?
   
   1. Update the usage for DLT.
   
   - Original text
   
   >Currently, dead letter topic is enabled only in the shared subscription mode.
   
   - Updated text
   
   >Currently, the dead letter topic can be enabled for all subscription types (`Exclusive`, `Failover`, `Key_Shared`, and `Shared`).
   
   2. Add the consequence of using DQL for ordered subscription type.
   
       Since we have [documented ](https://pulsar.apache.org/docs/en/next/concepts-messaging/#negative-acknowledgement) the consequence of using nack for ordered subscription types, should we add the consequence of using DQL for ordered subscription types as well?
   
   - Added text
   
   ```
   > **Note**
   >
   >  Using the dead letter topic on **ordered** subscription types (`Exclusive`, `Failover`, and `Key_Shared`) can cause messages to arrive consumers out of the original order.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org