[GitHub] [ranger] liujiayi771 opened a new pull request #45: [RANGER-2667] set controlName to allow-all when disable presto plugin

[GitBox <gi...@apache.org>]

liujiayi771 opened a new pull request #45: [RANGER-2667] set controlName to allow-all when disable presto plugin
URL: https://github.com/apache/ranger/pull/45
 
 
   Running the disable-presto-plugin.sh script will always get stuck. Because the script sets the
   controlName to an empty string and passes it to the function addOrUpdatePropertyToFile when disable the presto plugin. If controlName is an empty string, addOrUpdatePropertyToFile will ignore this parameter and let fn to be the second parameter. So $3 passed to checkPropertyInFile will be empty. In checkPropertyInFile, if the second parameter is empty, the sed command will never return, and the disable-presto-plugin.sh script will always get stuck.
   
   We should pass the default value of access-control.name and set controlName to be allow-all when disable presto plugin.
   
   JIRA: https://issues.apache.org/jira/browse/RANGER-2667

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services