You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/22 23:19:28 UTC
[GitHub] [airflow] ryanahamilton opened a new pull request #13857: Fix: Linux/Chrome window bouncing
ryanahamilton opened a new pull request #13857:
URL: https://github.com/apache/airflow/pull/13857
Closes #13713
The `min-height: 100vh;` was causing Linux/Chromium browsers to continually trigger the vertical scrollbar in and out of the window yielding a bouncing effect.
I'm confirmed this fix in a local VM running Chromium. @mattwelke and/or @INGCRENGIFO since you identified this behavior, maybe you could also confirm this fix works (by simply modifying in DevTools)?
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mattwelke edited a comment on pull request #13857: Fix: Linux/Chrome window bouncing
Posted by GitBox <gi...@apache.org>.
mattwelke edited a comment on pull request #13857:
URL: https://github.com/apache/airflow/pull/13857#issuecomment-765794497
@ryanahamilton
Woops that was silly. Running `pip install apache-airflow` instead, as the quickstart tells me, works. I get 2.0.0:
And I can confirm removing that CSS property fixed the bouncing issue:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mattwelke edited a comment on pull request #13857: Fix: Linux/Chrome window bouncing
Posted by GitBox <gi...@apache.org>.
mattwelke edited a comment on pull request #13857:
URL: https://github.com/apache/airflow/pull/13857#issuecomment-765792974
@ryanahamilton
I'm unable to reproduce the issue I originally raised using the latest published version of Airflow. I ran the steps from the quickstart and then the tutorial again, and I got this:
This UI looks different. It's much more minimalist. Tried multiple viewport widths but none had the "bouncing" problem.
It's weird though. It looks like despite running `pip install airflow`, I got some sort of deb build:
```
> airflow version
2.1.0.dev0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mattwelke commented on pull request #13857: Fix: Linux/Chrome window bouncing
Posted by GitBox <gi...@apache.org>.
mattwelke commented on pull request #13857:
URL: https://github.com/apache/airflow/pull/13857#issuecomment-765740774
Friday evenings are for tinkering for me. I'll try it out and let you know. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #13857: Fix: Linux/Chrome window bouncing
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #13857:
URL: https://github.com/apache/airflow/pull/13857#issuecomment-767033767
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #13857: Fix: Linux/Chrome window bouncing
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #13857:
URL: https://github.com/apache/airflow/pull/13857#issuecomment-765996187
I found an undesired side-effect of this update. Will be following up with a revision.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #13857: Fix: Linux/Chrome window bouncing
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #13857:
URL: https://github.com/apache/airflow/pull/13857#issuecomment-765810743
Thanks for confirming @mattwelke!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13857: Fix: Linux/Chrome window bouncing
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13857:
URL: https://github.com/apache/airflow/pull/13857#issuecomment-767084211
> One small aesthetic change resulting from this will be the position of the footer on views that don't have much vertical content. Instead of starting at the bottom of the browser window, it will start after the content.
>
> Before After
>  
😬 That does not look good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #13857: Fix: Linux/Chrome window bouncing
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #13857:
URL: https://github.com/apache/airflow/pull/13857#issuecomment-767132391
@kaxil after a bit more trial/error + cross-browser testing, I found an even simpler solution that has no impact on the aesthetics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton merged pull request #13857: Fix: Linux/Chrome window bouncing
Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #13857:
URL: https://github.com/apache/airflow/pull/13857
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mattwelke commented on pull request #13857: Fix: Linux/Chrome window bouncing
Posted by GitBox <gi...@apache.org>.
mattwelke commented on pull request #13857:
URL: https://github.com/apache/airflow/pull/13857#issuecomment-765792974
@ryanahamilton
I'm unable to reproduce the issue I originally raised using the latest published version of Airflow. I ran the steps from the quickstart and then the tutorial again, and I got this:
This UI looks different. It's much more minimalist. Tried multiple viewport widths but none had the "bouncing" problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton merged pull request #13857: Fix: Linux/Chrome window bouncing
Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #13857:
URL: https://github.com/apache/airflow/pull/13857
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13857: Fix: Linux/Chrome window bouncing
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13857:
URL: https://github.com/apache/airflow/pull/13857#issuecomment-765794957
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #13857: Fix: Linux/Chrome window bouncing
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #13857:
URL: https://github.com/apache/airflow/pull/13857#issuecomment-767033767
One small aesthetic change resulting from this will be the position of the footer on views that don't have much vertical content. Instead of starting at the bottom of the browser window, it will start after the content.
| Before | After |
|---|---|
|  |  |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mattwelke commented on pull request #13857: Fix: Linux/Chrome window bouncing
Posted by GitBox <gi...@apache.org>.
mattwelke commented on pull request #13857:
URL: https://github.com/apache/airflow/pull/13857#issuecomment-765794497
@ryanahamilton
Woops that was silly. Running `pip install apache-airflow` instead, as the quickstart tells me, works. I get 2.0.0. And I can confirm removing that CSS property fixed the bouncing issue:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13857: Fix: Linux/Chrome window bouncing
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13857:
URL: https://github.com/apache/airflow/pull/13857#issuecomment-767084211
> One small aesthetic change resulting from this will be the position of the footer on views that don't have much vertical content. Instead of starting at the bottom of the browser window, it will start after the content.
>
> Before After
>  
😬 That does not look good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org