You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@age.apache.org by GitBox <gi...@apache.org> on 2022/09/22 00:07:48 UTC

[GitHub] [age] ibrarahmad commented on issue #303: Review AGE for PostgreSQL 12

ibrarahmad commented on issue #303:
URL: https://github.com/apache/age/issues/303#issuecomment-1254352381

   The compilation is successful with no warnings at all
   
   ```
   vagrant@ubuntu-focal:~/bitnine/age$ make
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/age.o src/backend/age.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/catalog/ag_catalog.o src/backend/catalog/ag_catalog.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/catalog/ag_graph.o src/backend/catalog/ag_graph.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/catalog/ag_label.o src/backend/catalog/ag_label.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/catalog/ag_namespace.o src/backend/catalog/ag_namespace.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/commands/graph_commands.o src/backend/commands/graph_commands.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/commands/label_commands.o src/backend/commands/label_commands.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/executor/cypher_create.o src/backend/executor/cypher_create.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/executor/cypher_merge.o src/backend/executor/cypher_merge.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/executor/cypher_set.o src/backend/executor/cypher_set.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/executor/cypher_utils.o src/backend/executor/cypher_utils.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/nodes/ag_nodes.o src/backend/nodes/ag_nodes.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/nodes/cypher_copyfuncs.o src/backend/nodes/cypher_copyfuncs.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/nodes/cypher_outfuncs.o src/backend/nodes/cypher_outfuncs.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/nodes/cypher_readfuncs.o src/backend/nodes/cypher_readfuncs.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/optimizer/cypher_createplan.o src/backend/optimizer/cypher_createplan.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/optimizer/cypher_pathnode.o src/backend/optimizer/cypher_pathnode.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/optimizer/cypher_paths.o src/backend/optimizer/cypher_paths.c
   /usr/bin/flex -b  -o'src/backend/parser/ag_scanner.c' src/backend/parser/ag_scanner.l
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/parser/ag_scanner.o src/backend/parser/ag_scanner.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/parser/cypher_analyze.o src/backend/parser/cypher_analyze.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/parser/cypher_clause.o src/backend/parser/cypher_clause.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/executor/cypher_delete.o src/backend/executor/cypher_delete.c
   gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O0 -g3 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/usr/local/pgsql.12/include/server -I/usr/local/pgsql.12/include/internal  -D_GNU_SOURCE   -c -o src/backend/parser/cypher_expr.o src/backend/parser/cypher_expr.c
   /usr/bin/bison -Wno-deprecated  --defines=src/include/parser/cypher_gram_def.h -o
   
   ```
   
   Regression is also clear, with no failure.
   
   ```
   vagrant@ubuntu-focal:~/bitnine/age$ make installcheck 
   /usr/local/pgsql.12/lib/pgxs/src/makefiles/../../src/test/regress/pg_regress --inputdir=./ --bindir='/usr/local/pgsql.12/bin'    --load-extension=age --inputdir=.//regress --outputdir=.//regress --temp-instance=.//regress/instance --port=61958 --encoding=UTF-8 --dbname=contrib_regression scan graphid agtype catalog cypher expr cypher_create cypher_match cypher_unwind cypher_set cypher_remove cypher_delete cypher_with cypher_vle cypher_union cypher_merge age_load index drop
   ============== creating temporary instance            ==============
   ============== initializing database system           ==============
   ============== starting postmaster                    ==============
   running on port 61958 with PID 429106
   ============== creating database "contrib_regression" ==============
   CREATE DATABASE
   ALTER DATABASE
   ============== installing age                         ==============
   CREATE EXTENSION
   ============== running regression test queries        ==============
   test scan                         ... ok          182 ms
   test graphid                      ... ok           10 ms
   test agtype                       ... ok           76 ms
   test catalog                      ... ok           89 ms
   test cypher                       ... ok           17 ms
   test expr                         ... ok          448 ms
   test cypher_create                ... ok           92 ms
   test cypher_match                 ... ok          316 ms
   test cypher_unwind                ... ok           23 ms
   test cypher_set                   ... ok          132 ms
   test cypher_remove                ... ok           88 ms
   test cypher_delete                ... ok           94 ms
   test cypher_with                  ... ok           16 ms
   test cypher_vle                   ... ok         1361 ms
   test cypher_union                 ... ok           22 ms
   test cypher_merge                 ... ok          105 ms
   test age_load                     ... ok         1763 ms
   test index                        ... ok           81 ms
   test drop                         ... ok          276 ms
   ============== shutting down postmaster               ==============
   ============== removing temporary instance            ==============
   
   ======================
    All 19 tests passed. 
   ======================
   
   ```
   
   All set.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org