You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/25 09:01:43 UTC
[GitHub] flink pull request #3988: [FLINK-6715] Activate strict checkstyle for flink-...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3988
[FLINK-6715] Activate strict checkstyle for flink-mesos
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6715_cs_mesos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3988.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3988
----
commit 04500c86baa55d5318193a76c78c4708067b21ed
Author: zentol <ch...@apache.org>
Date: 2017-05-25T08:25:24Z
[FLINK-6715] Activate strict checkstyle for flink-mesos
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3988: [FLINK-6715] Activate strict checkstyle for flink-...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3988#discussion_r118477940
--- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java ---
@@ -284,8 +286,8 @@ public String toString() {
break;
case DOCKER:
- assert(params.containerImageName().isDefined());
- containerInfo
+ assert (params.containerImageName().isDefined());
--- End diff --
Was this change required / intended?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3988: [FLINK-6715] Activate strict checkstyle for flink-...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3988#discussion_r118480485
--- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java ---
@@ -284,8 +286,8 @@ public String toString() {
break;
case DOCKER:
- assert(params.containerImageName().isDefined());
- containerInfo
+ assert (params.containerImageName().isDefined());
--- End diff --
hmm. not sure, I'll double check later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3988: [FLINK-6715] Activate strict checkstyle for flink-...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3988
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3988: [FLINK-6715] Activate strict checkstyle for flink-...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3988#discussion_r118490372
--- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java ---
@@ -284,8 +286,8 @@ public String toString() {
break;
case DOCKER:
- assert(params.containerImageName().isDefined());
- containerInfo
+ assert (params.containerImageName().isDefined());
--- End diff --
Change is not required, will revert it while merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---