[GitHub] [ignite] AMashenkov commented on a change in pull request #6770: IGNITE-12061 Fix inline size change.

[GitBox <gi...@apache.org>]

AMashenkov commented on a change in pull request #6770: IGNITE-12061 Fix inline size change.
URL: https://github.com/apache/ignite/pull/6770#discussion_r315245317
 
 

 ##########
 File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/SchemaManager.java
 ##########
 @@ -616,6 +616,12 @@ public void dropIndex(final String schemaName, String idxName, boolean ifExists)
         throws IgniteCheckedException{
         String sql = H2Utils.indexDropSql(schemaName, idxName, ifExists);
 
+        GridH2Table tbl = dataTableForIndex(schemaName, idxName);
+
+        assert tbl != null;
+
+        tbl.setRemoveIndexOnDestroy(true);
 
 Review comment:
   Ivan, 
   Cache stop and  schema operations (e.g. index drop) causes PME and should be serialized.
   All schema operations are queued via GridQueryProcessor.schemaOps.
   Cache stop operation fall into GridQueryProcessor.onCacheStop0 where all schemaOps have cancelled right before 
   setRemoveIndexOnDestroy flag is changed (inside idx.unregisterCache() call).
   
   Possibly, GridQueryProcessor should wait for active SchemaOperationManager.worker-s before idx.unregisterCache(), but this should be investigated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services