You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Yong Tang <yo...@outlook.com> on 2016/04/04 01:46:15 UTC
Re: Review Request 45659: Changed some non-ascii characters in
libprocess to ascii equivalent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45659/
-----------------------------------------------------------
(Updated April 3, 2016, 11:46 p.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao.
Changes
-------
Update commit message and summary description.
Summary (updated)
-----------------
Changed some non-ascii characters in libprocess to ascii equivalent.
Bugs: MESOS-4033
https://issues.apache.org/jira/browse/MESOS-4033
Repository: mesos
Description (updated)
-------
This is part of MESOS-4033: Add a commit hook for checking non-ascii characters.
Note: The commit hook requires separate commits for libprocess and mesos.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp a1bfc808eb1b1c372acb028019901f0ab3f15238
Diff: https://reviews.apache.org/r/45659/diff/
Testing
-------
make check
Thanks,
Yong Tang
Re: Review Request 45659: Changed some non-ascii characters in
libprocess to ascii equivalent.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45659/#review126773
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On April 3, 2016, 11:46 p.m., Yong Tang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45659/
> -----------------------------------------------------------
>
> (Updated April 3, 2016, 11:46 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao.
>
>
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is part of MESOS-4033: Add a commit hook for checking non-ascii characters.
>
> Note: The commit hook requires separate commits for libprocess and mesos.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp a1bfc808eb1b1c372acb028019901f0ab3f15238
>
> Diff: https://reviews.apache.org/r/45659/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Yong Tang
>
>
Re: Review Request 45659: Changed some non-ascii characters in
libprocess to ascii equivalent.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45659/#review126939
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On April 4, 2016, 3:22 p.m., Yong Tang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45659/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 3:22 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao.
>
>
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is part of MESOS-4033: Add a commit hook for checking non-ascii characters.
>
> Note: The commit hook requires separate commits for libprocess and mesos.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp a1bfc808eb1b1c372acb028019901f0ab3f15238
>
> Diff: https://reviews.apache.org/r/45659/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Yong Tang
>
>
Re: Review Request 45659: Changed some non-ascii characters in
libprocess to ascii equivalent.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45659/#review126910
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 4, 2016, 3:22 p.m., Yong Tang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45659/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 3:22 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao.
>
>
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is part of MESOS-4033: Add a commit hook for checking non-ascii characters.
>
> Note: The commit hook requires separate commits for libprocess and mesos.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp a1bfc808eb1b1c372acb028019901f0ab3f15238
>
> Diff: https://reviews.apache.org/r/45659/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Yong Tang
>
>
Re: Review Request 45659: Changed some non-ascii characters in
libprocess to ascii equivalent.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On April 4, 2016, 9:24 p.m., Benjamin Bannier wrote:
> > Ship It!
Thanks for doing this, I could easily imagine issues like this slipping throuh in the past since I had to look trice :D
It might be a good idea to get these fixes in before the hook.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45659/#review126913
-----------------------------------------------------------
On April 4, 2016, 5:22 p.m., Yong Tang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45659/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 5:22 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao.
>
>
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is part of MESOS-4033: Add a commit hook for checking non-ascii characters.
>
> Note: The commit hook requires separate commits for libprocess and mesos.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp a1bfc808eb1b1c372acb028019901f0ab3f15238
>
> Diff: https://reviews.apache.org/r/45659/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Yong Tang
>
>
Re: Review Request 45659: Changed some non-ascii characters in
libprocess to ascii equivalent.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45659/#review126913
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On April 4, 2016, 5:22 p.m., Yong Tang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45659/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 5:22 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao.
>
>
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is part of MESOS-4033: Add a commit hook for checking non-ascii characters.
>
> Note: The commit hook requires separate commits for libprocess and mesos.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp a1bfc808eb1b1c372acb028019901f0ab3f15238
>
> Diff: https://reviews.apache.org/r/45659/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Yong Tang
>
>
Re: Review Request 45659: Changed some non-ascii characters in
libprocess to ascii equivalent.
Posted by Yong Tang <yo...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45659/
-----------------------------------------------------------
(Updated April 4, 2016, 3:22 p.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao.
Changes
-------
Update the review request as https://reviews.apache.org/r/45033/ has changed.
Bugs: MESOS-4033
https://issues.apache.org/jira/browse/MESOS-4033
Repository: mesos
Description
-------
This is part of MESOS-4033: Add a commit hook for checking non-ascii characters.
Note: The commit hook requires separate commits for libprocess and mesos.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp a1bfc808eb1b1c372acb028019901f0ab3f15238
Diff: https://reviews.apache.org/r/45659/diff/
Testing
-------
make check
Thanks,
Yong Tang
Re: Review Request 45659: Changed some non-ascii characters in
libprocess to ascii equivalent.
Posted by Yong Tang <yo...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45659/
-----------------------------------------------------------
(Updated April 4, 2016, 2:34 p.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao.
Changes
-------
Update the review request as https://reviews.apache.org/r/45033/ has changed.
Bugs: MESOS-4033
https://issues.apache.org/jira/browse/MESOS-4033
Repository: mesos
Description
-------
This is part of MESOS-4033: Add a commit hook for checking non-ascii characters.
Note: The commit hook requires separate commits for libprocess and mesos.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp a1bfc808eb1b1c372acb028019901f0ab3f15238
Diff: https://reviews.apache.org/r/45659/diff/
Testing
-------
make check
Thanks,
Yong Tang