You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "karsonto (via GitHub)" <gi...@apache.org> on 2023/12/15 08:58:18 UTC
[PR] [ISSUE #4654]Fix bug for mac get ip address (eventmesh)
karsonto opened a new pull request, #4655:
URL: https://github.com/apache/eventmesh/pull/4655
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #4654
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#discussion_r1439346871
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -59,14 +59,19 @@ public static String getLocalAddress() {
List<String> list = Arrays.asList(priority.split("<"));
ArrayList<String> preferList = new ArrayList<>(list);
NetworkInterface preferNetworkInterface = null;
+ boolean matchName = false;
try {
Enumeration<NetworkInterface> enumeration1 = NetworkInterface.getNetworkInterfaces();
while (enumeration1.hasMoreElements()) {
final NetworkInterface networkInterface = enumeration1.nextElement();
+ String name = networkInterface.getName();
+ if (preferList.contains(name)) {
+ matchName = true;
+ }
Review Comment:
Please rename `matchName` to `isInterfacePreferred` and `name` to `interfaceName` for better understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo merged PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#issuecomment-1864141547
Waiting for your response https://github.com/apache/eventmesh/pull/4655#issuecomment-1857761888 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#issuecomment-1864202626
> > Waiting for your response [#4655 (comment)](https://github.com/apache/eventmesh/pull/4655#issuecomment-1857761888) .
>
> sorry,i do not understand you meaning
Can condition `if(preferList.contains(name))` be changed to `if(!matchName && preferList.contains(name))`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "karsonto (via GitHub)" <gi...@apache.org>.
karsonto commented on code in PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#discussion_r1440291852
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -66,7 +66,7 @@ public static String getLocalAddress() {
while (enumeration1.hasMoreElements()) {
final NetworkInterface networkInterface = enumeration1.nextElement();
String interfaceName = networkInterface.getName();
- if (preferList.contains(interfaceName)) {
+ if (preferList.contains(interfaceName) && !isInterfacePreferred) {
Review Comment:
Yes,please review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "karsonto (via GitHub)" <gi...@apache.org>.
karsonto commented on code in PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#discussion_r1427804619
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -76,7 +81,7 @@ public static String getLocalAddress() {
ArrayList<String> ipv4Result = new ArrayList<String>();
ArrayList<String> ipv6Result = new ArrayList<String>();
- if (preferNetworkInterface != null) {
+ if (preferNetworkInterface != null && matchName) {
Review Comment:
https://github.com/apache/eventmesh/pull/4655#issuecomment-1857619267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#issuecomment-1859641194
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4655?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `1 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`958b041`)](https://app.codecov.io/gh/apache/eventmesh/commit/958b041c77b1aa074c993c69c34323c515f26712?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 17.28% compared to head [(`24863f4`)](https://app.codecov.io/gh/apache/eventmesh/pull/4655?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 17.39%.
> Report is 15 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/eventmesh/pull/4655?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ava/org/apache/eventmesh/common/utils/IPUtils.java](https://app.codecov.io/gh/apache/eventmesh/pull/4655?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9JUFV0aWxzLmphdmE=) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4655?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4655 +/- ##
============================================
+ Coverage 17.28% 17.39% +0.10%
- Complexity 1742 1760 +18
============================================
Files 792 797 +5
Lines 29703 29794 +91
Branches 2567 2577 +10
============================================
+ Hits 5134 5182 +48
- Misses 24095 24129 +34
- Partials 474 483 +9
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/eventmesh/pull/4655?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on code in PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#discussion_r1427776607
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -76,7 +81,7 @@ public static String getLocalAddress() {
ArrayList<String> ipv4Result = new ArrayList<String>();
ArrayList<String> ipv6Result = new ArrayList<String>();
- if (preferNetworkInterface != null) {
+ if (preferNetworkInterface != null && matchName) {
Review Comment:
I didn't understand what caused the bug, could you explain it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on code in PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#discussion_r1440289915
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -66,7 +66,7 @@ public static String getLocalAddress() {
while (enumeration1.hasMoreElements()) {
final NetworkInterface networkInterface = enumeration1.nextElement();
String interfaceName = networkInterface.getName();
- if (preferList.contains(interfaceName)) {
+ if (preferList.contains(interfaceName) && !isInterfacePreferred) {
Review Comment:
If `!isInterfacePreferred` is placed before `preferList.contains(interfaceName)`, the efficiency seems to be a little higher.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Fix bug for mac get ip address (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on code in PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#discussion_r1427776607
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -76,7 +81,7 @@ public static String getLocalAddress() {
ArrayList<String> ipv4Result = new ArrayList<String>();
ArrayList<String> ipv6Result = new ArrayList<String>();
- if (preferNetworkInterface != null) {
+ if (preferNetworkInterface != null && matchName) {
Review Comment:
I didn't understand what caused the bug, could you explain it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on code in PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#discussion_r1428761187
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -76,7 +81,7 @@ public static String getLocalAddress() {
ArrayList<String> ipv4Result = new ArrayList<String>();
ArrayList<String> ipv6Result = new ArrayList<String>();
- if (preferNetworkInterface != null) {
+ if (preferNetworkInterface != null && matchName) {
Review Comment:
@xwm1992 The modifications in this PR do not break the original logic, and they can also help some users avoid the trouble of manually changing jvm parameters and reduce the usage barriers. Is it appropriate to view this PR in this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "karsonto (via GitHub)" <gi...@apache.org>.
karsonto commented on code in PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#discussion_r1440018476
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -59,14 +59,19 @@ public static String getLocalAddress() {
List<String> list = Arrays.asList(priority.split("<"));
ArrayList<String> preferList = new ArrayList<>(list);
NetworkInterface preferNetworkInterface = null;
+ boolean matchName = false;
try {
Enumeration<NetworkInterface> enumeration1 = NetworkInterface.getNetworkInterfaces();
while (enumeration1.hasMoreElements()) {
final NetworkInterface networkInterface = enumeration1.nextElement();
+ String name = networkInterface.getName();
+ if (preferList.contains(name)) {
+ matchName = true;
+ }
Review Comment:
Thank you for your suggestion. I have already made the changes you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on code in PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#discussion_r1427971489
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -76,7 +81,7 @@ public static String getLocalAddress() {
ArrayList<String> ipv4Result = new ArrayList<String>();
ArrayList<String> ipv6Result = new ArrayList<String>();
- if (preferNetworkInterface != null) {
+ if (preferNetworkInterface != null && matchName) {
Review Comment:
I think this problem is because of the ipv6 config for jvm, you can configure the example jvm params with the ipv4 first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on code in PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#discussion_r1427793663
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -76,7 +81,7 @@ public static String getLocalAddress() {
ArrayList<String> ipv4Result = new ArrayList<String>();
ArrayList<String> ipv6Result = new ArrayList<String>();
- if (preferNetworkInterface != null) {
+ if (preferNetworkInterface != null && matchName) {
Review Comment:
I didn't understand the cause of the bug, could you explain it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on code in PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#discussion_r1428769297
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -76,7 +81,7 @@ public static String getLocalAddress() {
ArrayList<String> ipv4Result = new ArrayList<String>();
ArrayList<String> ipv6Result = new ArrayList<String>();
- if (preferNetworkInterface != null) {
+ if (preferNetworkInterface != null && matchName) {
Review Comment:
> @xwm1992 The modifications in this PR do not break the original logic, and they can also help some users avoid the trouble of manually changing jvm parameters and reduce the usage barriers. Is it appropriate to view this PR in this way?
I think the modified content of this pr is inconsistent with the described problem. You only need to configure the jvm parameters to adjust whether to use ipv4. There is no need to add `match` to judge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on code in PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#discussion_r1427971489
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -76,7 +81,7 @@ public static String getLocalAddress() {
ArrayList<String> ipv4Result = new ArrayList<String>();
ArrayList<String> ipv6Result = new ArrayList<String>();
- if (preferNetworkInterface != null) {
+ if (preferNetworkInterface != null && matchName) {
Review Comment:
I think this problem is because of the ipv6 config for jvm, you can configure the example jvm params with the ipv4 first. `-Djava.net.preferIPv4Stack=true` add this to your example jvm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "karsonto (via GitHub)" <gi...@apache.org>.
karsonto commented on PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#issuecomment-1864195675
> Waiting for your response [#4655 (comment)](https://github.com/apache/eventmesh/pull/4655#issuecomment-1857761888) .
sorry,i do not understand you meaning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "karsonto (via GitHub)" <gi...@apache.org>.
karsonto commented on PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#issuecomment-1875126154
> > > Waiting for your response [#4655 (comment)](https://github.com/apache/eventmesh/pull/4655#issuecomment-1857761888) .
> >
> >
> > sorry,i do not understand you meaning
>
> Can condition `if(preferList.contains(name))` be changed to `if(!matchName && preferList.contains(name))`?
Thank you for your suggestion. I have already made the changes you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "karsonto (via GitHub)" <gi...@apache.org>.
karsonto commented on PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#issuecomment-1878071830
@xwm1992 please review it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#issuecomment-1875100969
Waiting for author's response. https://github.com/apache/eventmesh/pull/4655#issuecomment-1864202626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "karsonto (via GitHub)" <gi...@apache.org>.
karsonto commented on PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#issuecomment-1857619267
<img width="1012" alt="image" src="https://github.com/apache/eventmesh/assets/31433550/8c68ce5c-f084-4605-b0b0-403744360dbe">
<img width="814" alt="image" src="https://github.com/apache/eventmesh/assets/31433550/108a036e-7972-43ac-9fe2-f912c67e8869">
Because the network interface address name does not match the default networkInterface.priority, preferNetworkInterface is always the first interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4654]Get Ip address problem when run example code (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#issuecomment-1857761888
> Because the network interface name does not match the default networkInterface.priority, preferNetworkInterface is always the first one.
Thank you for your explanation. Additionally, can a condition `!matchName` be added to `if(preferList.contains(name))`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org