[GitHub] [iceberg] pvary commented on a change in pull request #2252: Hive: removed Iceberg props should be removed from HMS table props too

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2252:
URL: https://github.com/apache/iceberg/pull/2252#discussion_r578592325



##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -186,7 +188,15 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) {
             baseMetadataLocation, metadataLocation, database, tableName);
       }
 
-      setHmsTableParameters(newMetadataLocation, tbl, metadata.properties(), hiveEngineEnabled);
+      // get Iceberg props that have been removed
+      List<String> removedProps = Collections.emptyList();

Review comment:
       Could this be a set?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org