You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Miguel Ferreira <mi...@me.com> on 2014/07/21 15:35:25 UTC
Review Request 23735: Fix deployment of data center with marvin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23735/
-----------------------------------------------------------
Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla, and Hugo Trippaers.
Repository: cloudstack-git
Description
-------
The DevCloud wiki page [1] instructs developers to deploy a DC with basic networking with the following command:
$ python tools/marvin/marvin/deployDataCenter.py -i tools/devcloud/devcloud-advanced.cfg
However, that produces the error message bellow:
Exception Occurred Under createLogs :['Traceback (most recent call last):\n', ' File "/Users/mferreira/development/git/cloudstack-sbp/tools/marvin/marvin/marvinLog.py", line 157, in createLogs\n (\'LogFolderPath\' in log_cfg.__dict__.keys()) and\n', "AttributeError: 'list' object has no attribute '__dict__'\n"]
===Log Creation Failed. Please Check===
The cause of the error is the unexpected format of the logger element in tools/devcloud/devcloud-advanced.cfg
The patch I'm submitting add support for lists in the logger element of the configuration.
In addition the patch also provides small fixes for the deployment configuration of basic and advanced zones.
[1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud
Diffs
-----
tools/devcloud/devcloud-advanced.cfg 74b6366
tools/devcloud/devcloud.cfg 5232e3a
tools/marvin/marvin/deployDataCenter.py ae48839
tools/marvin/marvin/marvinLog.py ea8eaee
Diff: https://reviews.apache.org/r/23735/diff/
Testing
-------
With the patch I was able to deploy a zone in cloudstack.
Thanks,
Miguel Ferreira
Re: Review Request 23735: Fix deployment of data center with marvin
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23735/#review79037
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On July 22, 2014, 7:24 a.m., Miguel Ferreira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23735/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 7:24 a.m.)
>
>
> Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla, and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The DevCloud wiki page [1] instructs developers to deploy a DC with basic networking with the following command:
> $ python tools/marvin/marvin/deployDataCenter.py -i tools/devcloud/devcloud-advanced.cfg
>
>
> However, that produces the error message bellow:
>
> Exception Occurred Under createLogs :['Traceback (most recent call last):\n', ' File "/Users/mferreira/development/git/cloudstack-sbp/tools/marvin/marvin/marvinLog.py", line 157, in createLogs\n (\'LogFolderPath\' in log_cfg.__dict__.keys()) and\n', "AttributeError: 'list' object has no attribute '__dict__'\n"]
>
> ===Log Creation Failed. Please Check===
>
>
> The cause of the error is the unexpected format of the logger element in tools/devcloud/devcloud-advanced.cfg
> The patch I'm submitting add support for lists in the logger element of the configuration.
>
> [1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud
>
>
> Diffs
> -----
>
> tools/marvin/marvin/deployDataCenter.py ae48839
> tools/marvin/marvin/marvinLog.py ea8eaee
>
> Diff: https://reviews.apache.org/r/23735/diff/
>
>
> Testing
> -------
>
> With the patch I was able to deploy a zone in cloudstack.
>
>
> Thanks,
>
> Miguel Ferreira
>
>
Re: Review Request 23735: Fix deployment of data center with marvin
Posted by Miguel Ferreira <mi...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23735/
-----------------------------------------------------------
(Updated July 22, 2014, 7:24 a.m.)
Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla, and Hugo Trippaers.
Repository: cloudstack-git
Description (updated)
-------
The DevCloud wiki page [1] instructs developers to deploy a DC with basic networking with the following command:
$ python tools/marvin/marvin/deployDataCenter.py -i tools/devcloud/devcloud-advanced.cfg
However, that produces the error message bellow:
Exception Occurred Under createLogs :['Traceback (most recent call last):\n', ' File "/Users/mferreira/development/git/cloudstack-sbp/tools/marvin/marvin/marvinLog.py", line 157, in createLogs\n (\'LogFolderPath\' in log_cfg.__dict__.keys()) and\n', "AttributeError: 'list' object has no attribute '__dict__'\n"]
===Log Creation Failed. Please Check===
The cause of the error is the unexpected format of the logger element in tools/devcloud/devcloud-advanced.cfg
The patch I'm submitting add support for lists in the logger element of the configuration.
[1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud
Diffs
-----
tools/marvin/marvin/deployDataCenter.py ae48839
tools/marvin/marvin/marvinLog.py ea8eaee
Diff: https://reviews.apache.org/r/23735/diff/
Testing
-------
With the patch I was able to deploy a zone in cloudstack.
Thanks,
Miguel Ferreira
Re: Review Request 23735: Fix deployment of data center with marvin
Posted by Miguel Ferreira <mi...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23735/
-----------------------------------------------------------
(Updated July 22, 2014, 7:24 a.m.)
Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla, and Hugo Trippaers.
Changes
-------
Remove changes to config files
Repository: cloudstack-git
Description
-------
The DevCloud wiki page [1] instructs developers to deploy a DC with basic networking with the following command:
$ python tools/marvin/marvin/deployDataCenter.py -i tools/devcloud/devcloud-advanced.cfg
However, that produces the error message bellow:
Exception Occurred Under createLogs :['Traceback (most recent call last):\n', ' File "/Users/mferreira/development/git/cloudstack-sbp/tools/marvin/marvin/marvinLog.py", line 157, in createLogs\n (\'LogFolderPath\' in log_cfg.__dict__.keys()) and\n', "AttributeError: 'list' object has no attribute '__dict__'\n"]
===Log Creation Failed. Please Check===
The cause of the error is the unexpected format of the logger element in tools/devcloud/devcloud-advanced.cfg
The patch I'm submitting add support for lists in the logger element of the configuration.
In addition the patch also provides small fixes for the deployment configuration of basic and advanced zones.
[1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud
Diffs (updated)
-----
tools/marvin/marvin/deployDataCenter.py ae48839
tools/marvin/marvin/marvinLog.py ea8eaee
Diff: https://reviews.apache.org/r/23735/diff/
Testing
-------
With the patch I was able to deploy a zone in cloudstack.
Thanks,
Miguel Ferreira
Re: Review Request 23735: Fix deployment of data center with marvin
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On July 21, 2014, 1:56 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/deployDataCenter.py, line 1099
> > <https://reviews.apache.org/r/23735/diff/1/?file=636741#file636741line1099>
> >
> > Instead of this, can we make "logger" node under devcloud.cfg as similar to setup/dev/advanced.cfg. We never see a case of for loop to create multiple loggers and logs?
> >
> >
>
> Miguel Ferreira wrote:
> There are more configurations that use lists of loggers then otherwise.
> I didn't assume on way t be better than another simply because I don't know.
>
> see:
> tools/marvin$ find .. -type f -iname '*.cfg' | xargs grep logger
> ../devcloud/devcloud-advanced.cfg: "logger": [
> ../devcloud/devcloud-advanced_internal-mgt.cfg: "logger": [
> ../devcloud/devcloud-advanced_juniper-contrail.cfg: "logger": [
> ../devcloud/devcloud-advancedsg.cfg: "logger": [
> ../devcloud/devcloud.cfg: "logger":
> ../devcloud/devcloud_internal-mgt.cfg: "logger": [
> ../devcloud/devcloud_s3.cfg: "logger": [
> ../devcloud/quickcloud.cfg: "logger": [
> ../devcloud-kvm/devcloud-kvm-advanced-fusion.cfg: "logger": {
> ../devcloud-kvm/devcloud-kvm-advanced.cfg: "logger": [
> ../devcloud-kvm/devcloud-kvm.cfg: "logger": [
> ../marvin/marvin/config/setup.cfg: "logger":
> ../marvin/marvin/misc/build/asf_test.cfg: "logger": [
> ../marvin/marvin/misc/build/kvm.cfg: "logger": [
> ../marvin/marvin/misc/build/xen.cfg: "logger": [
Yeah, there were few places where lists of loggers are used. Some of these config files are not used or rarely used. List of loggers support is not available inside framework, i.e., no differentiation between the earlier mentioned client and case log, so please follow according to advanced.cfg and if other cfgs needs modification, we can do accordingly.
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23735/#review48216
-----------------------------------------------------------
On July 22, 2014, 7:24 a.m., Miguel Ferreira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23735/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 7:24 a.m.)
>
>
> Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla, and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The DevCloud wiki page [1] instructs developers to deploy a DC with basic networking with the following command:
> $ python tools/marvin/marvin/deployDataCenter.py -i tools/devcloud/devcloud-advanced.cfg
>
>
> However, that produces the error message bellow:
>
> Exception Occurred Under createLogs :['Traceback (most recent call last):\n', ' File "/Users/mferreira/development/git/cloudstack-sbp/tools/marvin/marvin/marvinLog.py", line 157, in createLogs\n (\'LogFolderPath\' in log_cfg.__dict__.keys()) and\n', "AttributeError: 'list' object has no attribute '__dict__'\n"]
>
> ===Log Creation Failed. Please Check===
>
>
> The cause of the error is the unexpected format of the logger element in tools/devcloud/devcloud-advanced.cfg
> The patch I'm submitting add support for lists in the logger element of the configuration.
>
> [1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud
>
>
> Diffs
> -----
>
> tools/marvin/marvin/deployDataCenter.py ae48839
> tools/marvin/marvin/marvinLog.py ea8eaee
>
> Diff: https://reviews.apache.org/r/23735/diff/
>
>
> Testing
> -------
>
> With the patch I was able to deploy a zone in cloudstack.
>
>
> Thanks,
>
> Miguel Ferreira
>
>
Re: Review Request 23735: Fix deployment of data center with marvin
Posted by Miguel Ferreira <mi...@me.com>.
> On July 21, 2014, 1:56 p.m., Santhosh Edukulla wrote:
> > tools/devcloud/devcloud-advanced.cfg, line 133
> > <https://reviews.apache.org/r/23735/diff/1/?file=636739#file636739line133>
> >
> > Is this change required, compared to earlier devcloud cfg, it was a working cfg for devcloud.
That would only work if the MS would be running in the devcloud machine.
In my case (and I guess in most cases as well), when developing, the MS will be launched from the IDE (e.g. eclipse), and that wouldn't work.
> On July 21, 2014, 1:56 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/deployDataCenter.py, line 1099
> > <https://reviews.apache.org/r/23735/diff/1/?file=636741#file636741line1099>
> >
> > Instead of this, can we make "logger" node under devcloud.cfg as similar to setup/dev/advanced.cfg. We never see a case of for loop to create multiple loggers and logs?
> >
> >
There are more configurations that use lists of loggers then otherwise.
I didn't assume on way t be better than another simply because I don't know.
see:
tools/marvin$ find .. -type f -iname '*.cfg' | xargs grep logger
../devcloud/devcloud-advanced.cfg: "logger": [
../devcloud/devcloud-advanced_internal-mgt.cfg: "logger": [
../devcloud/devcloud-advanced_juniper-contrail.cfg: "logger": [
../devcloud/devcloud-advancedsg.cfg: "logger": [
../devcloud/devcloud.cfg: "logger":
../devcloud/devcloud_internal-mgt.cfg: "logger": [
../devcloud/devcloud_s3.cfg: "logger": [
../devcloud/quickcloud.cfg: "logger": [
../devcloud-kvm/devcloud-kvm-advanced-fusion.cfg: "logger": {
../devcloud-kvm/devcloud-kvm-advanced.cfg: "logger": [
../devcloud-kvm/devcloud-kvm.cfg: "logger": [
../marvin/marvin/config/setup.cfg: "logger":
../marvin/marvin/misc/build/asf_test.cfg: "logger": [
../marvin/marvin/misc/build/kvm.cfg: "logger": [
../marvin/marvin/misc/build/xen.cfg: "logger": [
- Miguel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23735/#review48216
-----------------------------------------------------------
On July 21, 2014, 1:35 p.m., Miguel Ferreira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23735/
> -----------------------------------------------------------
>
> (Updated July 21, 2014, 1:35 p.m.)
>
>
> Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla, and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The DevCloud wiki page [1] instructs developers to deploy a DC with basic networking with the following command:
> $ python tools/marvin/marvin/deployDataCenter.py -i tools/devcloud/devcloud-advanced.cfg
>
>
> However, that produces the error message bellow:
>
> Exception Occurred Under createLogs :['Traceback (most recent call last):\n', ' File "/Users/mferreira/development/git/cloudstack-sbp/tools/marvin/marvin/marvinLog.py", line 157, in createLogs\n (\'LogFolderPath\' in log_cfg.__dict__.keys()) and\n', "AttributeError: 'list' object has no attribute '__dict__'\n"]
>
> ===Log Creation Failed. Please Check===
>
>
> The cause of the error is the unexpected format of the logger element in tools/devcloud/devcloud-advanced.cfg
> The patch I'm submitting add support for lists in the logger element of the configuration.
>
> In addition the patch also provides small fixes for the deployment configuration of basic and advanced zones.
>
>
> [1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud
>
>
> Diffs
> -----
>
> tools/devcloud/devcloud-advanced.cfg 74b6366
> tools/devcloud/devcloud.cfg 5232e3a
> tools/marvin/marvin/deployDataCenter.py ae48839
> tools/marvin/marvin/marvinLog.py ea8eaee
>
> Diff: https://reviews.apache.org/r/23735/diff/
>
>
> Testing
> -------
>
> With the patch I was able to deploy a zone in cloudstack.
>
>
> Thanks,
>
> Miguel Ferreira
>
>
Re: Review Request 23735: Fix deployment of data center with marvin
Posted by Miguel Ferreira <mi...@me.com>.
> On July 21, 2014, 1:56 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/marvinLog.py, line 168
> > <https://reviews.apache.org/r/23735/diff/1/?file=636742#file636742line168>
> >
> > Make it more abstract and see if is not aware of cfg(log_cfg), i mean pass the logfile path, as similar to create log from directory, where we pass log folder dir.
>
> Santhosh Edukulla wrote:
> Make it more abstract and see if is not aware of cfg(log_cfg), i mean pass the logfile path, as similar to create log from directory, where we pass log folder dir.
>
>
> Miguel Ferreira wrote:
> I don't see where where is the difference in abstraction level you mention.
> Both methods createLogFromFile and createLogFromDirectory receive a log_cfg object, that is already received as a parameter from the method above in the call stack (createLogs). Thus, all three methods are at the same abstraction level in that respect.
Do you mean making createLogFromFile and createLogFromDirectory agnostic about the log_cfg structure?
Cause that seems an improvement to me.
- Miguel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23735/#review48216
-----------------------------------------------------------
On July 22, 2014, 7:24 a.m., Miguel Ferreira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23735/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 7:24 a.m.)
>
>
> Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla, and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The DevCloud wiki page [1] instructs developers to deploy a DC with basic networking with the following command:
> $ python tools/marvin/marvin/deployDataCenter.py -i tools/devcloud/devcloud-advanced.cfg
>
>
> However, that produces the error message bellow:
>
> Exception Occurred Under createLogs :['Traceback (most recent call last):\n', ' File "/Users/mferreira/development/git/cloudstack-sbp/tools/marvin/marvin/marvinLog.py", line 157, in createLogs\n (\'LogFolderPath\' in log_cfg.__dict__.keys()) and\n', "AttributeError: 'list' object has no attribute '__dict__'\n"]
>
> ===Log Creation Failed. Please Check===
>
>
> The cause of the error is the unexpected format of the logger element in tools/devcloud/devcloud-advanced.cfg
> The patch I'm submitting add support for lists in the logger element of the configuration.
>
> [1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud
>
>
> Diffs
> -----
>
> tools/marvin/marvin/deployDataCenter.py ae48839
> tools/marvin/marvin/marvinLog.py ea8eaee
>
> Diff: https://reviews.apache.org/r/23735/diff/
>
>
> Testing
> -------
>
> With the patch I was able to deploy a zone in cloudstack.
>
>
> Thanks,
>
> Miguel Ferreira
>
>
Re: Review Request 23735: Fix deployment of data center with marvin
Posted by Miguel Ferreira <mi...@me.com>.
> On July 21, 2014, 1:56 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/marvinLog.py, line 168
> > <https://reviews.apache.org/r/23735/diff/1/?file=636742#file636742line168>
> >
> > Make it more abstract and see if is not aware of cfg(log_cfg), i mean pass the logfile path, as similar to create log from directory, where we pass log folder dir.
>
> Santhosh Edukulla wrote:
> Make it more abstract and see if is not aware of cfg(log_cfg), i mean pass the logfile path, as similar to create log from directory, where we pass log folder dir.
>
I don't see where where is the difference in abstraction level you mention.
Both methods createLogFromFile and createLogFromDirectory receive a log_cfg object, that is already received as a parameter from the method above in the call stack (createLogs). Thus, all three methods are at the same abstraction level in that respect.
- Miguel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23735/#review48216
-----------------------------------------------------------
On July 22, 2014, 7:24 a.m., Miguel Ferreira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23735/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 7:24 a.m.)
>
>
> Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla, and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The DevCloud wiki page [1] instructs developers to deploy a DC with basic networking with the following command:
> $ python tools/marvin/marvin/deployDataCenter.py -i tools/devcloud/devcloud-advanced.cfg
>
>
> However, that produces the error message bellow:
>
> Exception Occurred Under createLogs :['Traceback (most recent call last):\n', ' File "/Users/mferreira/development/git/cloudstack-sbp/tools/marvin/marvin/marvinLog.py", line 157, in createLogs\n (\'LogFolderPath\' in log_cfg.__dict__.keys()) and\n', "AttributeError: 'list' object has no attribute '__dict__'\n"]
>
> ===Log Creation Failed. Please Check===
>
>
> The cause of the error is the unexpected format of the logger element in tools/devcloud/devcloud-advanced.cfg
> The patch I'm submitting add support for lists in the logger element of the configuration.
>
> [1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud
>
>
> Diffs
> -----
>
> tools/marvin/marvin/deployDataCenter.py ae48839
> tools/marvin/marvin/marvinLog.py ea8eaee
>
> Diff: https://reviews.apache.org/r/23735/diff/
>
>
> Testing
> -------
>
> With the patch I was able to deploy a zone in cloudstack.
>
>
> Thanks,
>
> Miguel Ferreira
>
>
Re: Review Request 23735: Fix deployment of data center with marvin
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On July 21, 2014, 1:56 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/marvinLog.py, line 168
> > <https://reviews.apache.org/r/23735/diff/1/?file=636742#file636742line168>
> >
> > Make it more abstract and see if is not aware of cfg(log_cfg), i mean pass the logfile path, as similar to create log from directory, where we pass log folder dir.
Make it more abstract and see if is not aware of cfg(log_cfg), i mean pass the logfile path, as similar to create log from directory, where we pass log folder dir.
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23735/#review48216
-----------------------------------------------------------
On July 22, 2014, 7:24 a.m., Miguel Ferreira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23735/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 7:24 a.m.)
>
>
> Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla, and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The DevCloud wiki page [1] instructs developers to deploy a DC with basic networking with the following command:
> $ python tools/marvin/marvin/deployDataCenter.py -i tools/devcloud/devcloud-advanced.cfg
>
>
> However, that produces the error message bellow:
>
> Exception Occurred Under createLogs :['Traceback (most recent call last):\n', ' File "/Users/mferreira/development/git/cloudstack-sbp/tools/marvin/marvin/marvinLog.py", line 157, in createLogs\n (\'LogFolderPath\' in log_cfg.__dict__.keys()) and\n', "AttributeError: 'list' object has no attribute '__dict__'\n"]
>
> ===Log Creation Failed. Please Check===
>
>
> The cause of the error is the unexpected format of the logger element in tools/devcloud/devcloud-advanced.cfg
> The patch I'm submitting add support for lists in the logger element of the configuration.
>
> [1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud
>
>
> Diffs
> -----
>
> tools/marvin/marvin/deployDataCenter.py ae48839
> tools/marvin/marvin/marvinLog.py ea8eaee
>
> Diff: https://reviews.apache.org/r/23735/diff/
>
>
> Testing
> -------
>
> With the patch I was able to deploy a zone in cloudstack.
>
>
> Thanks,
>
> Miguel Ferreira
>
>
Re: Review Request 23735: Fix deployment of data center with marvin
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23735/#review48216
-----------------------------------------------------------
tools/devcloud/devcloud-advanced.cfg
<https://reviews.apache.org/r/23735/#comment84571>
Is this change required, compared to earlier devcloud cfg, it was a working cfg for devcloud.
tools/marvin/marvin/deployDataCenter.py
<https://reviews.apache.org/r/23735/#comment84569>
Instead of this, can we make "logger" node under devcloud.cfg as similar to setup/dev/advanced.cfg. We never see a case of for loop to create multiple loggers and logs?
tools/marvin/marvin/marvinLog.py
<https://reviews.apache.org/r/23735/#comment84570>
Make it more abstract and see if is not aware of cfg(log_cfg), i mean pass the logfile path, as similar to create log from directory, where we pass log folder dir.
tools/marvin/marvin/marvinLog.py
<https://reviews.apache.org/r/23735/#comment84572>
As well, not related to this line though, can we please test using the simulator and advanced.cfg to launch management server and deploy a datacenter.
- Santhosh Edukulla
On July 21, 2014, 1:35 p.m., Miguel Ferreira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23735/
> -----------------------------------------------------------
>
> (Updated July 21, 2014, 1:35 p.m.)
>
>
> Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla, and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The DevCloud wiki page [1] instructs developers to deploy a DC with basic networking with the following command:
> $ python tools/marvin/marvin/deployDataCenter.py -i tools/devcloud/devcloud-advanced.cfg
>
>
> However, that produces the error message bellow:
>
> Exception Occurred Under createLogs :['Traceback (most recent call last):\n', ' File "/Users/mferreira/development/git/cloudstack-sbp/tools/marvin/marvin/marvinLog.py", line 157, in createLogs\n (\'LogFolderPath\' in log_cfg.__dict__.keys()) and\n', "AttributeError: 'list' object has no attribute '__dict__'\n"]
>
> ===Log Creation Failed. Please Check===
>
>
> The cause of the error is the unexpected format of the logger element in tools/devcloud/devcloud-advanced.cfg
> The patch I'm submitting add support for lists in the logger element of the configuration.
>
> In addition the patch also provides small fixes for the deployment configuration of basic and advanced zones.
>
>
> [1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud
>
>
> Diffs
> -----
>
> tools/devcloud/devcloud-advanced.cfg 74b6366
> tools/devcloud/devcloud.cfg 5232e3a
> tools/marvin/marvin/deployDataCenter.py ae48839
> tools/marvin/marvin/marvinLog.py ea8eaee
>
> Diff: https://reviews.apache.org/r/23735/diff/
>
>
> Testing
> -------
>
> With the patch I was able to deploy a zone in cloudstack.
>
>
> Thanks,
>
> Miguel Ferreira
>
>
Re: Review Request 23735: Fix deployment of data center with marvin
Posted by Miguel Ferreira <mi...@me.com>.
> On July 21, 2014, 1:58 p.m., Hugo Trippaers wrote:
> > tools/devcloud/devcloud-advanced.cfg, line 133
> > <https://reviews.apache.org/r/23735/diff/1/?file=636739#file636739line133>
> >
> > For devcloud deployments the mgtSvrIp should be .10 as the management server is running on the devcloud itself.
Doesn't seem the most logical from a development perspective, but if that's the norm then no changes to this file are needed.
- Miguel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23735/#review48217
-----------------------------------------------------------
On July 21, 2014, 1:35 p.m., Miguel Ferreira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23735/
> -----------------------------------------------------------
>
> (Updated July 21, 2014, 1:35 p.m.)
>
>
> Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla, and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The DevCloud wiki page [1] instructs developers to deploy a DC with basic networking with the following command:
> $ python tools/marvin/marvin/deployDataCenter.py -i tools/devcloud/devcloud-advanced.cfg
>
>
> However, that produces the error message bellow:
>
> Exception Occurred Under createLogs :['Traceback (most recent call last):\n', ' File "/Users/mferreira/development/git/cloudstack-sbp/tools/marvin/marvin/marvinLog.py", line 157, in createLogs\n (\'LogFolderPath\' in log_cfg.__dict__.keys()) and\n', "AttributeError: 'list' object has no attribute '__dict__'\n"]
>
> ===Log Creation Failed. Please Check===
>
>
> The cause of the error is the unexpected format of the logger element in tools/devcloud/devcloud-advanced.cfg
> The patch I'm submitting add support for lists in the logger element of the configuration.
>
> In addition the patch also provides small fixes for the deployment configuration of basic and advanced zones.
>
>
> [1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud
>
>
> Diffs
> -----
>
> tools/devcloud/devcloud-advanced.cfg 74b6366
> tools/devcloud/devcloud.cfg 5232e3a
> tools/marvin/marvin/deployDataCenter.py ae48839
> tools/marvin/marvin/marvinLog.py ea8eaee
>
> Diff: https://reviews.apache.org/r/23735/diff/
>
>
> Testing
> -------
>
> With the patch I was able to deploy a zone in cloudstack.
>
>
> Thanks,
>
> Miguel Ferreira
>
>
Re: Review Request 23735: Fix deployment of data center with marvin
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23735/#review48217
-----------------------------------------------------------
tools/devcloud/devcloud-advanced.cfg
<https://reviews.apache.org/r/23735/#comment84573>
For devcloud deployments the mgtSvrIp should be .10 as the management server is running on the devcloud itself.
- Hugo Trippaers
On July 21, 2014, 1:35 p.m., Miguel Ferreira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23735/
> -----------------------------------------------------------
>
> (Updated July 21, 2014, 1:35 p.m.)
>
>
> Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla, and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The DevCloud wiki page [1] instructs developers to deploy a DC with basic networking with the following command:
> $ python tools/marvin/marvin/deployDataCenter.py -i tools/devcloud/devcloud-advanced.cfg
>
>
> However, that produces the error message bellow:
>
> Exception Occurred Under createLogs :['Traceback (most recent call last):\n', ' File "/Users/mferreira/development/git/cloudstack-sbp/tools/marvin/marvin/marvinLog.py", line 157, in createLogs\n (\'LogFolderPath\' in log_cfg.__dict__.keys()) and\n', "AttributeError: 'list' object has no attribute '__dict__'\n"]
>
> ===Log Creation Failed. Please Check===
>
>
> The cause of the error is the unexpected format of the logger element in tools/devcloud/devcloud-advanced.cfg
> The patch I'm submitting add support for lists in the logger element of the configuration.
>
> In addition the patch also provides small fixes for the deployment configuration of basic and advanced zones.
>
>
> [1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud
>
>
> Diffs
> -----
>
> tools/devcloud/devcloud-advanced.cfg 74b6366
> tools/devcloud/devcloud.cfg 5232e3a
> tools/marvin/marvin/deployDataCenter.py ae48839
> tools/marvin/marvin/marvinLog.py ea8eaee
>
> Diff: https://reviews.apache.org/r/23735/diff/
>
>
> Testing
> -------
>
> With the patch I was able to deploy a zone in cloudstack.
>
>
> Thanks,
>
> Miguel Ferreira
>
>