You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/02/23 23:23:02 UTC

[GitHub] [geode] demery-pivotal commented on a change in pull request #7387: GEODE-8140: Set scope field in gfsh.

demery-pivotal commented on a change in pull request #7387:
URL: https://github.com/apache/geode/pull/7387#discussion_r813415472



##########
File path: geode-wan/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommandDUnitTest.java
##########
@@ -33,6 +37,7 @@
 import org.apache.geode.test.junit.rules.serializable.SerializableTestName;
 
 @Category({WanTest.class})
+@RunWith(JUnitParamsRunner.class)

Review comment:
       Please use `GeodeParamsRunner` instead. `JUnitParamsRunner` is incompatible with JUnit Platform, which we now use to run tests.
   
   `GeodeParamsRunner` extends `JUnitParamsRunner`, so you can use it the same way in tests. But it overrides `JUnitParamsRunner` to make it more compatible with JUnit Platform.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org