You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "SvenRoederer (via GitHub)" <gi...@apache.org> on 2024/07/10 22:56:40 UTC
[PR] make GitHubActions also run tests for netstd (updated) [thrift]
SvenRoederer opened a new pull request, #2998:
URL: https://github.com/apache/thrift/pull/2998
Add a job to build and run tests for netstd. Also upload the binaries as artifact.
This gives basic testing, but leaves including to cross-test for the future.
Most job-steps are copied from the other jobs.
In relation to https://github.com/apache/thrift/pull/2994 it already uses ubuntu-22.04 (ubuntu-20.04 has issues with dotnet-support).
This PR supersedes #2995 to apply straight forward on master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] make GitHubActions also run tests for netstd (updated) [thrift]
Posted by "SvenRoederer (via GitHub)" <gi...@apache.org>.
SvenRoederer commented on code in PR #2998:
URL: https://github.com/apache/thrift/pull/2998#discussion_r1691201860
##########
.github/workflows/build.yml:
##########
@@ -297,6 +297,67 @@ jobs:
lib/kotlin/cross-test-server/build/install/TestServer/
retention-days: 3
+ lib-netstd:
+ needs: compiler
+ runs-on: ubuntu-22.04
+ strategy:
+ fail-fast: false
+ steps:
+ - uses: actions/checkout@v4
+
+ - name: Install dependencies
+ run: |
+ sudo apt-get update -yq
+ sudo apt-get install -y --no-install-recommends $BUILD_DEPS
+ sudo apt-get install -y --no-install-recommends curl openssl ca-certificates
+
+# the sdk is installed by default, but keep this step for reference
+# - name: Set up .NET SDK
+# run: |
+# sudo apt-get install -y --no-install-recommends dotnet-sdk-8.0
+
+ - name: Run bootstrap
+ run: ./bootstrap.sh
+
+ - name: Run configure for netstd
+ run: |
+ ./configure $(echo $CONFIG_ARGS_FOR_LIBS | sed 's/without-netstd/with-netstd/')
+
+ - uses: actions/download-artifact@v3
+ with:
+ name: thrift-compiler
+ path: compiler/cpp
+
+ - name: Run thrift-compiler
+ run: |
+ chmod a+x compiler/cpp/thrift
+ compiler/cpp/thrift -version
+
+ - name: Run make for netstd
+ run: make -C lib/netstd
+
+ - name: Run make install for netstd
+ run: sudo make -C lib/netstd install
+
+ - name: Run make check for netstd
+ run: make -C lib/netstd check
+
+ - name: Run make check for test/netstd
+ run: make -C test/netstd check
+
+ - name: Run make precross for test/netstd
+ run: make -C test/netstd precross
+
+ - name: Upload netstd precross artifacts
+ uses: actions/upload-artifact@v3
+ with:
Review Comment:
done. all artifact-actions are v4 now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] make GitHubActions also run tests for netstd (updated) [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G merged PR #2998:
URL: https://github.com/apache/thrift/pull/2998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] make GitHubActions also run tests for netstd (updated) [thrift]
Posted by "SvenRoederer (via GitHub)" <gi...@apache.org>.
SvenRoederer commented on code in PR #2998:
URL: https://github.com/apache/thrift/pull/2998#discussion_r1691194400
##########
.github/workflows/build.yml:
##########
@@ -297,6 +297,67 @@ jobs:
lib/kotlin/cross-test-server/build/install/TestServer/
retention-days: 3
+ lib-netstd:
+ needs: compiler
+ runs-on: ubuntu-22.04
+ strategy:
+ fail-fast: false
+ steps:
+ - uses: actions/checkout@v4
+
+ - name: Install dependencies
+ run: |
+ sudo apt-get update -yq
+ sudo apt-get install -y --no-install-recommends $BUILD_DEPS
+ sudo apt-get install -y --no-install-recommends curl openssl ca-certificates
+
+# the sdk is installed by default, but keep this step for reference
+# - name: Set up .NET SDK
+# run: |
+# sudo apt-get install -y --no-install-recommends dotnet-sdk-8.0
+
+ - name: Run bootstrap
+ run: ./bootstrap.sh
+
+ - name: Run configure for netstd
+ run: |
+ ./configure $(echo $CONFIG_ARGS_FOR_LIBS | sed 's/without-netstd/with-netstd/')
+
+ - uses: actions/download-artifact@v3
+ with:
+ name: thrift-compiler
+ path: compiler/cpp
+
+ - name: Run thrift-compiler
+ run: |
+ chmod a+x compiler/cpp/thrift
+ compiler/cpp/thrift -version
+
+ - name: Run make for netstd
+ run: make -C lib/netstd
+
+ - name: Run make install for netstd
+ run: sudo make -C lib/netstd install
+
+ - name: Run make check for netstd
+ run: make -C lib/netstd check
+
+ - name: Run make check for test/netstd
+ run: make -C test/netstd check
+
+ - name: Run make precross for test/netstd
+ run: make -C test/netstd precross
+
+ - name: Upload netstd precross artifacts
+ uses: actions/upload-artifact@v3
+ with:
Review Comment:
... but when after merging the above PR, this commit needs to be updated to `upload-artifact@v3`. I can change and push here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] make GitHubActions also run tests for netstd (updated) [thrift]
Posted by "SvenRoederer (via GitHub)" <gi...@apache.org>.
SvenRoederer commented on PR #2998:
URL: https://github.com/apache/thrift/pull/2998#issuecomment-2231388105
Test failing with "python_test" for msvc builds - quite sure this does not relate to to the GitHubAction changes here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] make GitHubActions also run tests for netstd (updated) [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on code in PR #2998:
URL: https://github.com/apache/thrift/pull/2998#discussion_r1690375297
##########
.github/workflows/build.yml:
##########
@@ -297,6 +297,67 @@ jobs:
lib/kotlin/cross-test-server/build/install/TestServer/
retention-days: 3
+ lib-netstd:
+ needs: compiler
+ runs-on: ubuntu-22.04
+ strategy:
+ fail-fast: false
+ steps:
+ - uses: actions/checkout@v4
+
+ - name: Install dependencies
+ run: |
+ sudo apt-get update -yq
+ sudo apt-get install -y --no-install-recommends $BUILD_DEPS
+ sudo apt-get install -y --no-install-recommends curl openssl ca-certificates
+
+# the sdk is installed by default, but keep this step for reference
+# - name: Set up .NET SDK
+# run: |
+# sudo apt-get install -y --no-install-recommends dotnet-sdk-8.0
+
+ - name: Run bootstrap
+ run: ./bootstrap.sh
+
+ - name: Run configure for netstd
+ run: |
+ ./configure $(echo $CONFIG_ARGS_FOR_LIBS | sed 's/without-netstd/with-netstd/')
+
+ - uses: actions/download-artifact@v3
+ with:
+ name: thrift-compiler
+ path: compiler/cpp
+
+ - name: Run thrift-compiler
+ run: |
+ chmod a+x compiler/cpp/thrift
+ compiler/cpp/thrift -version
+
+ - name: Run make for netstd
+ run: make -C lib/netstd
+
+ - name: Run make install for netstd
+ run: sudo make -C lib/netstd install
+
+ - name: Run make check for netstd
+ run: make -C lib/netstd check
+
+ - name: Run make check for test/netstd
+ run: make -C test/netstd check
+
+ - name: Run make precross for test/netstd
+ run: make -C test/netstd precross
+
+ - name: Upload netstd precross artifacts
+ uses: actions/upload-artifact@v3
+ with:
Review Comment:
https://github.com/actions/upload-artifact is scheduled for deprecation on November 30, 2024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] make GitHubActions also run tests for netstd (updated) [thrift]
Posted by "SvenRoederer (via GitHub)" <gi...@apache.org>.
SvenRoederer commented on code in PR #2998:
URL: https://github.com/apache/thrift/pull/2998#discussion_r1691168787
##########
.github/workflows/build.yml:
##########
@@ -297,6 +297,67 @@ jobs:
lib/kotlin/cross-test-server/build/install/TestServer/
retention-days: 3
+ lib-netstd:
+ needs: compiler
+ runs-on: ubuntu-22.04
+ strategy:
+ fail-fast: false
+ steps:
+ - uses: actions/checkout@v4
+
+ - name: Install dependencies
+ run: |
+ sudo apt-get update -yq
+ sudo apt-get install -y --no-install-recommends $BUILD_DEPS
+ sudo apt-get install -y --no-install-recommends curl openssl ca-certificates
+
+# the sdk is installed by default, but keep this step for reference
+# - name: Set up .NET SDK
+# run: |
+# sudo apt-get install -y --no-install-recommends dotnet-sdk-8.0
+
+ - name: Run bootstrap
+ run: ./bootstrap.sh
+
+ - name: Run configure for netstd
+ run: |
+ ./configure $(echo $CONFIG_ARGS_FOR_LIBS | sed 's/without-netstd/with-netstd/')
+
+ - uses: actions/download-artifact@v3
+ with:
+ name: thrift-compiler
+ path: compiler/cpp
+
+ - name: Run thrift-compiler
+ run: |
+ chmod a+x compiler/cpp/thrift
+ compiler/cpp/thrift -version
+
+ - name: Run make for netstd
+ run: make -C lib/netstd
+
+ - name: Run make install for netstd
+ run: sudo make -C lib/netstd install
+
+ - name: Run make check for netstd
+ run: make -C lib/netstd check
+
+ - name: Run make check for test/netstd
+ run: make -C test/netstd check
+
+ - name: Run make precross for test/netstd
+ run: make -C test/netstd precross
+
+ - name: Upload netstd precross artifacts
+ uses: actions/upload-artifact@v3
+ with:
Review Comment:
upgrading this is part of #2994 (89506d34b3901483f7f78d0ea22d92ef090f44bf), as all uses need to be of the same version to work with each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org