You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/04 18:25:57 UTC

[GitHub] [spark] juliuszsompolski commented on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

juliuszsompolski commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639028923


   Could you add a test that fails before and is fixed after this change to HiveThriftServerBinarySuite (for JDBC) and CLISuite? I think it could be similar to the test for SPARK-31861?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org