[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #156: [BugFix] Filter null value when selecting remote storage in ApplicationManager

[GitBox <gi...@apache.org>]

smallzhongfeng commented on code in PR #156:
URL: https://github.com/apache/incubator-uniffle/pull/156#discussion_r944145739


##########
coordinator/src/test/java/org/apache/uniffle/coordinator/ApplicationManagerTest.java:
##########
@@ -98,6 +98,24 @@ public void refreshTest() {
     assertFalse(applicationManager.hasErrorInStatusCheck());
   }
 
+  @Test
+  public void pickRemoteStorageTest() {
+    String remoteStoragePath = remotePath1 + Constants.COMMA_SPLIT_CHAR + remotePath2;

Review Comment:
   Yes, because there is no better way to introduce a null value. This happens when I manually add a null value to the `sizeList` in the `pickRemoteStorage` method. Because this test is similar to `refreshTest`, I think one method and one test will be better. WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org