You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (Jira)" <ji...@apache.org> on 2019/09/03 02:41:00 UTC
[jira] [Resolved] (ARROW-6411) [C++][Parquet]
DictEncoderImpl::PutIndicesTyped has bad performance on some systems
[ https://issues.apache.org/jira/browse/ARROW-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wes McKinney resolved ARROW-6411.
---------------------------------
Resolution: Fixed
Issue resolved by pull request 5248
[https://github.com/apache/arrow/pull/5248]
> [C++][Parquet] DictEncoderImpl<T>::PutIndicesTyped has bad performance on some systems
> --------------------------------------------------------------------------------------
>
> Key: ARROW-6411
> URL: https://issues.apache.org/jira/browse/ARROW-6411
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Wes McKinney
> Assignee: Wes McKinney
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.15.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I was doing some benchmarking and noticed that this function showed up as slow due to {{\_\_memmove_avx_unaligned_erms}}. I'm interested to investigate why this is, but for me it's fixed by changing the {{std::vector::reserve}} call to {{std::vector::resize}} and instead assigning elements into {{buffered_indices_}}. I'll add a Python benchmark that illustrates the problem to see if it shows up on other systems
--
This message was sent by Atlassian Jira
(v8.3.2#803003)