You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Kyra Pritzel-Hentley (JIRA)" <ji...@apache.org> on 2018/01/04 11:14:00 UTC

[jira] [Updated] (OFBIZ-10143) Hardcoded String in PaymentGatewayServices#processCaptureResult

     [ https://issues.apache.org/jira/browse/OFBIZ-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kyra Pritzel-Hentley updated OFBIZ-10143:
-----------------------------------------
    Attachment: OFBIZ-10143_processCaptureResult_String.patch

In this patch a hard coded String is replaced with a String variable, trailing whitespace is deleted and a small typo is fixed.

> Hardcoded String in PaymentGatewayServices#processCaptureResult
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-10143
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10143
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Kyra Pritzel-Hentley
>            Priority: Trivial
>         Attachments: OFBIZ-10143_processCaptureResult_String.patch
>
>
> {code:java}
> // otherwise default to Company and print a big warning about this
> partyIdTo = "Company";
> Debug.logWarning("Using default value of [" + partyIdTo + "] for payTo on invoice [" + invoiceId + "] and orderPaymentPreference ["
> + paymentPreference.getString("orderPaymentPreferenceId") + "]", module);
> {code}
> partyIdTo default value should be final String.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)