[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #2333: Core: fix bug that HadoopFileIO cannot be dynamically loaded

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #2333:
URL: https://github.com/apache/iceberg/pull/2333#discussion_r594407742



##########
File path: core/src/main/java/org/apache/iceberg/CatalogUtil.java
##########
@@ -215,16 +216,27 @@ public static FileIO loadFileIO(
       Configuration hadoopConf) {
     LOG.info("Loading custom FileIO implementation: {}", impl);
     DynConstructors.Ctor<FileIO> ctor;
+    boolean useNoArgConstructor = true;
     try {
       ctor = DynConstructors.builder(FileIO.class).impl(impl).buildChecked();
     } catch (NoSuchMethodException e) {
-      throw new IllegalArgumentException(String.format(
-          "Cannot initialize FileIO, missing no-arg constructor: %s", impl), e);
+      LOG.error("No-arg constructor not found for {}, try to use Hadoop Configuration constructor", impl, e);

Review comment:
       try -> will attempt to use
   
   Just because the current wording makes it sound like the user needs to try to do something




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org