You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2023/04/04 18:36:59 UTC
[camel] branch main updated: Fixed concatenations with empty string (#9805)
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new f50b85bd461 Fixed concatenations with empty string (#9805)
f50b85bd461 is described below
commit f50b85bd4612df618fadbdd7bf28138fc25e6aa5
Author: dk2k <dk...@users.noreply.github.com>
AuthorDate: Tue Apr 4 21:36:53 2023 +0300
Fixed concatenations with empty string (#9805)
* Fixed concatenations with empty string - substituted with <Type>.toString() or String.valueOf()
* Fixed checkstyle issues
---------
Co-authored-by: dk2k <dk...@ya.ru>
---
.../apache/camel/parser/helper/CamelJavaParserHelper.java | 2 +-
.../camel/parser/helper/CamelJavaRestDslParserHelper.java | 2 +-
.../camel/parser/helper/CamelJavaTreeParserHelper.java | 2 +-
.../camel/component/as2/api/InvalidAS2NameException.java | 2 +-
.../java/org/apache/camel/component/jms/JmsProducer.java | 2 +-
.../jsonpath/easypredicate/EasyPredicateOperators.java | 4 ++--
.../org/apache/camel/component/kafka/KafkaConsumer.java | 2 +-
.../org/apache/camel/component/mail/MailConfiguration.java | 6 +++---
.../org/apache/camel/component/mock/MockValueBuilder.java | 2 +-
.../java/org/apache/camel/openapi/RestOpenApiSupport.java | 4 ++--
.../java/org/apache/camel/tracing/ActiveSpanManager.java | 8 ++++----
.../camel/component/weather/WeatherConfiguration.java | 2 +-
.../camel/impl/engine/DefaultManagementNameStrategy.java | 2 +-
.../camel/impl/cloud/DefaultServiceCallExpression.java | 2 +-
.../org/apache/camel/language/csimple/CSimpleHelper.java | 4 ++--
.../camel/language/simple/SimpleExpressionBuilder.java | 2 +-
.../org/apache/camel/language/simple/SimpleTokenizer.java | 2 +-
.../camel/language/simple/ast/BooleanExpression.java | 2 +-
.../camel/language/simple/ast/NumericExpression.java | 2 +-
.../java/org/apache/camel/builder/ExpressionClause.java | 2 +-
.../org/apache/camel/builder/ExpressionClauseSupport.java | 4 ++--
.../main/java/org/apache/camel/builder/NotifyBuilder.java | 4 ++--
.../apache/camel/main/DefaultConfigurationConfigurer.java | 3 ++-
.../org/apache/camel/management/mbean/LoadThroughput.java | 2 +-
.../mbean/ManagedAsyncProcessorAwaitManager.java | 4 ++--
.../camel/management/mbean/ManagedInflightRepository.java | 4 ++--
.../camel/management/mbean/RouteCoverageXmlParser.java | 14 +++++++-------
.../apache/camel/management/mbean/StatisticCounter.java | 2 +-
.../org/apache/camel/management/mbean/StatisticDelta.java | 2 +-
.../apache/camel/management/mbean/StatisticMaximum.java | 2 +-
.../apache/camel/management/mbean/StatisticMinimum.java | 2 +-
.../org/apache/camel/management/mbean/StatisticValue.java | 2 +-
.../apache/camel/support/builder/ExpressionBuilder.java | 6 +++---
.../org/apache/camel/support/builder/PredicateBuilder.java | 2 +-
.../org/apache/camel/support/builder/ValueBuilder.java | 2 +-
.../src/main/java/org/apache/camel/util/FileUtil.java | 4 ++--
.../src/main/java/org/apache/camel/util/StringHelper.java | 2 +-
.../src/main/java/org/apache/camel/util/UnitUtils.java | 4 ++--
.../src/main/java/org/apache/camel/xml/io/MXParser.java | 2 +-
.../dsl/jbang/core/commands/action/CamelLogAction.java | 2 +-
.../dsl/jbang/core/commands/action/CamelThreadDump.java | 10 +++++-----
.../dsl/jbang/core/commands/action/CamelTraceAction.java | 4 ++--
.../camel/dsl/jbang/core/commands/action/LoggerAction.java | 2 +-
.../jbang/core/commands/action/RouteControllerAction.java | 2 +-
.../jbang/core/commands/process/CamelContextStatus.java | 2 +-
.../dsl/jbang/core/commands/process/CamelContextTop.java | 2 +-
.../camel/dsl/jbang/core/commands/process/CamelCount.java | 2 +-
.../jbang/core/commands/process/CamelProcessorStatus.java | 2 +-
.../dsl/jbang/core/commands/process/CamelRouteStatus.java | 2 +-
.../camel/dsl/jbang/core/commands/process/Hawtio.java | 2 +-
.../camel/dsl/jbang/core/commands/process/Jolokia.java | 4 ++--
.../camel/dsl/jbang/core/commands/process/ListBlocked.java | 2 +-
.../jbang/core/commands/process/ListCircuitBreaker.java | 10 +++++-----
.../dsl/jbang/core/commands/process/ListEndpoint.java | 2 +-
.../camel/dsl/jbang/core/commands/process/ListEvent.java | 2 +-
.../camel/dsl/jbang/core/commands/process/ListHealth.java | 2 +-
.../dsl/jbang/core/commands/process/ListInflight.java | 2 +-
.../camel/dsl/jbang/core/commands/process/ListMetric.java | 4 ++--
.../camel/dsl/jbang/core/commands/process/ListProcess.java | 2 +-
.../camel/dsl/jbang/core/commands/process/ListService.java | 2 +-
.../camel/dsl/jbang/core/commands/process/ListVault.java | 2 +-
.../camel/dsl/jbang/core/commands/process/StopProcess.java | 2 +-
.../apache/camel/dsl/jbang/core/common/RuntimeUtil.java | 2 +-
.../java/org/apache/camel/main/http/VertxHttpServer.java | 2 +-
64 files changed, 98 insertions(+), 97 deletions(-)
diff --git a/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaParserHelper.java b/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaParserHelper.java
index a214cc93a60..200e8d6d4a9 100644
--- a/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaParserHelper.java
+++ b/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaParserHelper.java
@@ -606,7 +606,7 @@ public final class CamelJavaParserHelper {
if (expression instanceof StringLiteral) {
return ((StringLiteral) expression).getLiteralValue();
} else if (expression instanceof BooleanLiteral) {
- return "" + ((BooleanLiteral) expression).booleanValue();
+ return String.valueOf(((BooleanLiteral) expression).booleanValue());
} else if (expression instanceof NumberLiteral) {
return ((NumberLiteral) expression).getToken();
}
diff --git a/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaRestDslParserHelper.java b/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaRestDslParserHelper.java
index b33ae36c7d2..d788ab3c37f 100644
--- a/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaRestDslParserHelper.java
+++ b/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaRestDslParserHelper.java
@@ -509,7 +509,7 @@ public final class CamelJavaRestDslParserHelper {
if (expression instanceof StringLiteral) {
return ((StringLiteral) expression).getLiteralValue();
} else if (expression instanceof BooleanLiteral) {
- return "" + ((BooleanLiteral) expression).booleanValue();
+ return String.valueOf(((BooleanLiteral) expression).booleanValue());
} else if (expression instanceof NumberLiteral) {
return ((NumberLiteral) expression).getToken();
}
diff --git a/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaTreeParserHelper.java b/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaTreeParserHelper.java
index fda54847f7d..1c90bf5f3ce 100644
--- a/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaTreeParserHelper.java
+++ b/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaTreeParserHelper.java
@@ -349,7 +349,7 @@ public final class CamelJavaTreeParserHelper {
if (expression instanceof StringLiteral) {
return ((StringLiteral) expression).getLiteralValue();
} else if (expression instanceof BooleanLiteral) {
- return "" + ((BooleanLiteral) expression).booleanValue();
+ return String.valueOf(((BooleanLiteral) expression).booleanValue());
} else if (expression instanceof NumberLiteral) {
return ((NumberLiteral) expression).getToken();
}
diff --git a/components/camel-as2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/InvalidAS2NameException.java b/components/camel-as2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/InvalidAS2NameException.java
index 5ad194e2c78..e687868ae20 100644
--- a/components/camel-as2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/InvalidAS2NameException.java
+++ b/components/camel-as2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/InvalidAS2NameException.java
@@ -44,7 +44,7 @@ public class InvalidAS2NameException extends Exception {
@Override
public String getMessage() {
char character = name.charAt(index);
- String invalidChar = "" + character;
+ String invalidChar = String.valueOf(character);
if (Character.isISOControl(character)) {
invalidChar = String.format("\\u%04x", (int) character);
}
diff --git a/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsProducer.java b/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsProducer.java
index b08ea389b72..1fcb6ad032c 100644
--- a/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsProducer.java
+++ b/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsProducer.java
@@ -316,7 +316,7 @@ public class JmsProducer extends DefaultAsyncProducer {
// prefer to use destination over destination name
destinationName = null;
}
- final String to = destinationName != null ? destinationName : "" + destination;
+ final String to = destinationName != null ? destinationName : String.valueOf(destination);
MessageSentCallback messageSentCallback = getEndpoint().getConfiguration().isIncludeSentJMSMessageID()
? new InOnlyMessageSentCallback(exchange) : null;
diff --git a/components/camel-jsonpath/src/main/java/org/apache/camel/jsonpath/easypredicate/EasyPredicateOperators.java b/components/camel-jsonpath/src/main/java/org/apache/camel/jsonpath/easypredicate/EasyPredicateOperators.java
index 27b874ee9c4..1e4607bed5e 100644
--- a/components/camel-jsonpath/src/main/java/org/apache/camel/jsonpath/easypredicate/EasyPredicateOperators.java
+++ b/components/camel-jsonpath/src/main/java/org/apache/camel/jsonpath/easypredicate/EasyPredicateOperators.java
@@ -46,7 +46,7 @@ public final class EasyPredicateOperators {
*/
static boolean hasOperator(String exp) {
// need to have space around operator to not match eg in used in some other word
- return Arrays.stream(OPS).anyMatch(o -> exp.contains(" " + o + ""));
+ return Arrays.stream(OPS).anyMatch(o -> exp.contains(" " + o));
}
/**
@@ -60,7 +60,7 @@ public final class EasyPredicateOperators {
* Gets the operator (with single space around)
*/
static String getOperatorAtStart(String exp) {
- return Arrays.stream(OPS).filter(o -> exp.startsWith(" " + o + "")).findFirst().orElse(null);
+ return Arrays.stream(OPS).filter(o -> exp.startsWith(" " + o)).findFirst().orElse(null);
}
}
diff --git a/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaConsumer.java b/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaConsumer.java
index dad29c73ad5..247395fab3c 100644
--- a/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaConsumer.java
+++ b/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaConsumer.java
@@ -157,7 +157,7 @@ public class KafkaConsumer extends DefaultConsumer
BridgeExceptionHandlerToErrorHandler bridge = new BridgeExceptionHandlerToErrorHandler(this);
for (int i = 0; i < endpoint.getConfiguration().getConsumersCount(); i++) {
KafkaFetchRecords task = new KafkaFetchRecords(
- this, bridge, topic, pattern, i + "", getProps(), consumerListener);
+ this, bridge, topic, pattern, Integer.toString(i), getProps(), consumerListener);
executor.submit(task);
diff --git a/components/camel-mail/src/main/java/org/apache/camel/component/mail/MailConfiguration.java b/components/camel-mail/src/main/java/org/apache/camel/component/mail/MailConfiguration.java
index 03e3800cd07..e196e52de5a 100644
--- a/components/camel-mail/src/main/java/org/apache/camel/component/mail/MailConfiguration.java
+++ b/components/camel-mail/src/main/java/org/apache/camel/component/mail/MailConfiguration.java
@@ -272,7 +272,7 @@ public class MailConfiguration implements Cloneable {
properties.put("mail." + protocol + ".connectiontimeout", connectionTimeout);
properties.put("mail." + protocol + ".timeout", connectionTimeout);
properties.put("mail." + protocol + ".host", host);
- properties.put("mail." + protocol + ".port", "" + port);
+ properties.put("mail." + protocol + ".port", Integer.toString(port));
String pUserName = getPasswordAuthentication().getUserName();
if (pUserName != null) {
properties.put("mail." + protocol + ".user", pUserName);
@@ -293,11 +293,11 @@ public class MailConfiguration implements Cloneable {
if (sslContextParameters != null && isSecureProtocol()) {
properties.put("mail." + protocol + ".socketFactory", createSSLContext(context).getSocketFactory());
properties.put("mail." + protocol + ".socketFactory.fallback", "false");
- properties.put("mail." + protocol + ".socketFactory.port", "" + port);
+ properties.put("mail." + protocol + ".socketFactory.port", Integer.toString(port));
}
if (sslContextParameters != null && isStartTlsEnabled()) {
properties.put("mail." + protocol + ".ssl.socketFactory", createSSLContext(context).getSocketFactory());
- properties.put("mail." + protocol + ".ssl.socketFactory.port", "" + port);
+ properties.put("mail." + protocol + ".ssl.socketFactory.port", Integer.toString(port));
}
return properties;
diff --git a/components/camel-mock/src/main/java/org/apache/camel/component/mock/MockValueBuilder.java b/components/camel-mock/src/main/java/org/apache/camel/component/mock/MockValueBuilder.java
index 31aaf1c4175..cbd655d1c44 100644
--- a/components/camel-mock/src/main/java/org/apache/camel/component/mock/MockValueBuilder.java
+++ b/components/camel-mock/src/main/java/org/apache/camel/component/mock/MockValueBuilder.java
@@ -221,7 +221,7 @@ public class MockValueBuilder implements Expression, Predicate {
}
public MockValueBuilder tokenize(String token, int group, boolean skipFirst) {
- return tokenize(token, "" + group, skipFirst);
+ return tokenize(token, Integer.toString(group), skipFirst);
}
public MockValueBuilder tokenize(String token, String group, boolean skipFirst) {
diff --git a/components/camel-openapi-java/src/main/java/org/apache/camel/openapi/RestOpenApiSupport.java b/components/camel-openapi-java/src/main/java/org/apache/camel/openapi/RestOpenApiSupport.java
index 446f95c46bc..0c32527a496 100644
--- a/components/camel-openapi-java/src/main/java/org/apache/camel/openapi/RestOpenApiSupport.java
+++ b/components/camel-openapi-java/src/main/java/org/apache/camel/openapi/RestOpenApiSupport.java
@@ -413,7 +413,7 @@ public class RestOpenApiSupport {
Object dump = io.apicurio.datamodels.Library.writeNode(openApi);
byte[] bytes = mapper.writeValueAsBytes(dump);
int len = bytes.length;
- response.setHeader(Exchange.CONTENT_LENGTH, "" + len);
+ response.setHeader(Exchange.CONTENT_LENGTH, Integer.toString(len));
response.writeBytes(bytes);
} else {
@@ -439,7 +439,7 @@ public class RestOpenApiSupport {
byte[] bytes = new YAMLMapper().writeValueAsString(node).getBytes();
int len = bytes.length;
- response.setHeader(Exchange.CONTENT_LENGTH, "" + len);
+ response.setHeader(Exchange.CONTENT_LENGTH, Integer.toString(len));
response.writeBytes(bytes);
}
diff --git a/components/camel-tracing/src/main/java/org/apache/camel/tracing/ActiveSpanManager.java b/components/camel-tracing/src/main/java/org/apache/camel/tracing/ActiveSpanManager.java
index bce194f27ec..b9c502a49f0 100644
--- a/components/camel-tracing/src/main/java/org/apache/camel/tracing/ActiveSpanManager.java
+++ b/components/camel-tracing/src/main/java/org/apache/camel/tracing/ActiveSpanManager.java
@@ -59,8 +59,8 @@ public final class ActiveSpanManager {
exchange.setProperty(ACTIVE_SPAN_PROPERTY,
new Holder((Holder) exchange.getProperty(ACTIVE_SPAN_PROPERTY), span));
if (exchange.getContext().isUseMDCLogging()) {
- MDC.put(MDC_TRACE_ID, "" + span.traceId());
- MDC.put(MDC_SPAN_ID, "" + span.spanId());
+ MDC.put(MDC_TRACE_ID, span.traceId());
+ MDC.put(MDC_SPAN_ID, span.spanId());
}
}
@@ -81,8 +81,8 @@ public final class ActiveSpanManager {
Holder parent = holder.getParent();
if (parent != null) {
SpanAdapter span = holder.getParent().getSpan();
- MDC.put(MDC_TRACE_ID, "" + span.traceId());
- MDC.put(MDC_SPAN_ID, "" + span.spanId());
+ MDC.put(MDC_TRACE_ID, span.traceId());
+ MDC.put(MDC_SPAN_ID, span.spanId());
} else {
MDC.remove(MDC_TRACE_ID);
MDC.remove(MDC_SPAN_ID);
diff --git a/components/camel-weather/src/main/java/org/apache/camel/component/weather/WeatherConfiguration.java b/components/camel-weather/src/main/java/org/apache/camel/component/weather/WeatherConfiguration.java
index fc192fb6008..39b59a3dc9a 100644
--- a/components/camel-weather/src/main/java/org/apache/camel/component/weather/WeatherConfiguration.java
+++ b/components/camel-weather/src/main/java/org/apache/camel/component/weather/WeatherConfiguration.java
@@ -106,7 +106,7 @@ public class WeatherConfiguration {
// ignore and fallback the period to be an empty string
}
if (result != 0) {
- this.period = "" + result;
+ this.period = Integer.toString(result);
}
}
diff --git a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultManagementNameStrategy.java b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultManagementNameStrategy.java
index 9b0659b2fbb..88e22fa3dfc 100644
--- a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultManagementNameStrategy.java
+++ b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultManagementNameStrategy.java
@@ -118,7 +118,7 @@ public class DefaultManagementNameStrategy implements ManagementNameStrategy {
String answer = pattern;
if (pattern.contains("#counter#")) {
// only increment the counter on-demand
- answer = pattern.replace("#counter#", "" + nextNameCounter());
+ answer = pattern.replace("#counter#", Long.toString(nextNameCounter()));
}
// camelId and name is the same tokens
answer = answer.replace("#camelId#", name);
diff --git a/core/camel-cloud/src/main/java/org/apache/camel/impl/cloud/DefaultServiceCallExpression.java b/core/camel-cloud/src/main/java/org/apache/camel/impl/cloud/DefaultServiceCallExpression.java
index 8615f6d074d..1cbb8255425 100644
--- a/core/camel-cloud/src/main/java/org/apache/camel/impl/cloud/DefaultServiceCallExpression.java
+++ b/core/camel-cloud/src/main/java/org/apache/camel/impl/cloud/DefaultServiceCallExpression.java
@@ -55,7 +55,7 @@ public class DefaultServiceCallExpression extends ServiceCallExpressionSupport {
answer = answer.replaceFirst(name + "\\.host", host);
}
if (answer.contains(name + ".port") && port != null) {
- answer = answer.replaceFirst(name + "\\.port", "" + port);
+ answer = answer.replaceFirst(name + "\\.port", Integer.toString(port));
}
if (answer.contains(name) && port != null) {
answer = answer.replaceFirst(name, host + ":" + port);
diff --git a/core/camel-core-languages/src/main/java/org/apache/camel/language/csimple/CSimpleHelper.java b/core/camel-core-languages/src/main/java/org/apache/camel/language/csimple/CSimpleHelper.java
index 1954cc00d75..e96c68b9c2b 100644
--- a/core/camel-core-languages/src/main/java/org/apache/camel/language/csimple/CSimpleHelper.java
+++ b/core/camel-core-languages/src/main/java/org/apache/camel/language/csimple/CSimpleHelper.java
@@ -80,7 +80,7 @@ public final class CSimpleHelper {
}
public static <T> T bodyAsIndex(Message message, Class<T> type, int key) {
- return bodyAsIndex(message, type, "" + key);
+ return bodyAsIndex(message, type, Integer.toString(key));
}
public static <T> T bodyAsIndex(Message message, Class<T> type, String key) {
@@ -102,7 +102,7 @@ public final class CSimpleHelper {
}
public static <T> T mandatoryBodyAsIndex(Message message, Class<T> type, int key) throws InvalidPayloadException {
- T out = bodyAsIndex(message, type, "" + key);
+ T out = bodyAsIndex(message, type, Integer.toString(key));
if (out == null) {
throw new InvalidPayloadException(message.getExchange(), type, message);
}
diff --git a/core/camel-core-languages/src/main/java/org/apache/camel/language/simple/SimpleExpressionBuilder.java b/core/camel-core-languages/src/main/java/org/apache/camel/language/simple/SimpleExpressionBuilder.java
index 47593d3f48d..96c56e6afb3 100644
--- a/core/camel-core-languages/src/main/java/org/apache/camel/language/simple/SimpleExpressionBuilder.java
+++ b/core/camel-core-languages/src/main/java/org/apache/camel/language/simple/SimpleExpressionBuilder.java
@@ -144,7 +144,7 @@ public final class SimpleExpressionBuilder {
// first use simple then create the group expression
exp = context.resolveLanguage("simple").createExpression(expression);
exp.init(context);
- exp = ExpressionBuilder.groupIteratorExpression(exp, null, "" + group, false);
+ exp = ExpressionBuilder.groupIteratorExpression(exp, null, Integer.toString(group), false);
exp.init(context);
}
diff --git a/core/camel-core-languages/src/main/java/org/apache/camel/language/simple/SimpleTokenizer.java b/core/camel-core-languages/src/main/java/org/apache/camel/language/simple/SimpleTokenizer.java
index 3a0eb1b1f83..df30325f3d6 100644
--- a/core/camel-core-languages/src/main/java/org/apache/camel/language/simple/SimpleTokenizer.java
+++ b/core/camel-core-languages/src/main/java/org/apache/camel/language/simple/SimpleTokenizer.java
@@ -228,7 +228,7 @@ public final class SimpleTokenizer {
// fallback and create a character token
char ch = expression.charAt(index);
- SimpleToken token = new SimpleToken(new SimpleTokenType(TokenType.character, "" + ch), index);
+ SimpleToken token = new SimpleToken(new SimpleTokenType(TokenType.character, String.valueOf(ch)), index);
return token;
}
diff --git a/core/camel-core-languages/src/main/java/org/apache/camel/language/simple/ast/BooleanExpression.java b/core/camel-core-languages/src/main/java/org/apache/camel/language/simple/ast/BooleanExpression.java
index 92e575b80a0..eec56f05212 100644
--- a/core/camel-core-languages/src/main/java/org/apache/camel/language/simple/ast/BooleanExpression.java
+++ b/core/camel-core-languages/src/main/java/org/apache/camel/language/simple/ast/BooleanExpression.java
@@ -47,7 +47,7 @@ public class BooleanExpression extends BaseSimpleNode {
@Override
public String toString() {
- return "" + value;
+ return String.valueOf(value);
}
};
}
diff --git a/core/camel-core-languages/src/main/java/org/apache/camel/language/simple/ast/NumericExpression.java b/core/camel-core-languages/src/main/java/org/apache/camel/language/simple/ast/NumericExpression.java
index 4b15a908faf..ceda57ef05b 100644
--- a/core/camel-core-languages/src/main/java/org/apache/camel/language/simple/ast/NumericExpression.java
+++ b/core/camel-core-languages/src/main/java/org/apache/camel/language/simple/ast/NumericExpression.java
@@ -66,7 +66,7 @@ public class NumericExpression extends BaseSimpleNode {
@Override
public String toString() {
- return "" + number;
+ return String.valueOf(number);
}
};
}
diff --git a/core/camel-core-model/src/main/java/org/apache/camel/builder/ExpressionClause.java b/core/camel-core-model/src/main/java/org/apache/camel/builder/ExpressionClause.java
index 62df53d83fa..5bf24c7a106 100644
--- a/core/camel-core-model/src/main/java/org/apache/camel/builder/ExpressionClause.java
+++ b/core/camel-core-model/src/main/java/org/apache/camel/builder/ExpressionClause.java
@@ -785,7 +785,7 @@ public class ExpressionClause<T> implements Expression, Predicate {
* @return the builder to continue processing the DSL
*/
public T tokenize(String token, boolean regex, int group, String groupDelimiter, boolean skipFirst) {
- return delegate.tokenize(token, null, regex, "" + group, groupDelimiter, skipFirst);
+ return delegate.tokenize(token, null, regex, Integer.toString(group), groupDelimiter, skipFirst);
}
/**
diff --git a/core/camel-core-model/src/main/java/org/apache/camel/builder/ExpressionClauseSupport.java b/core/camel-core-model/src/main/java/org/apache/camel/builder/ExpressionClauseSupport.java
index 2bb79abd0de..0b82109918d 100644
--- a/core/camel-core-model/src/main/java/org/apache/camel/builder/ExpressionClauseSupport.java
+++ b/core/camel-core-model/src/main/java/org/apache/camel/builder/ExpressionClauseSupport.java
@@ -967,7 +967,7 @@ public class ExpressionClauseSupport<T> implements ExpressionFactoryAware, Predi
* @return the builder to continue processing the DSL
*/
public T tokenize(String token, String headerName, boolean regex, int group, boolean skipFirst) {
- return tokenize(token, headerName, regex, "" + group, skipFirst);
+ return tokenize(token, headerName, regex, Integer.toString(group), skipFirst);
}
/**
@@ -1033,7 +1033,7 @@ public class ExpressionClauseSupport<T> implements ExpressionFactoryAware, Predi
* @return the builder to continue processing the DSL
*/
public T tokenizeXMLPair(String tagName, String inheritNamespaceTagName, int group) {
- return tokenizeXMLPair(tagName, inheritNamespaceTagName, "" + group);
+ return tokenizeXMLPair(tagName, inheritNamespaceTagName, Integer.toString(group));
}
/**
diff --git a/core/camel-core-model/src/main/java/org/apache/camel/builder/NotifyBuilder.java b/core/camel-core-model/src/main/java/org/apache/camel/builder/NotifyBuilder.java
index 7d9da9ad3f2..ce66b3acbc5 100644
--- a/core/camel-core-model/src/main/java/org/apache/camel/builder/NotifyBuilder.java
+++ b/core/camel-core-model/src/main/java/org/apache/camel/builder/NotifyBuilder.java
@@ -962,9 +962,9 @@ public class NotifyBuilder {
@Override
public String toString() {
if (received) {
- return "" + (exact ? "whenExactBodiesReceived(" : "whenBodiesReceived(") + bodies + ")";
+ return (exact ? "whenExactBodiesReceived(" : "whenBodiesReceived(") + bodies + ")";
} else {
- return "" + (exact ? "whenExactBodiesDone(" : "whenBodiesDone(") + bodies + ")";
+ return (exact ? "whenExactBodiesDone(" : "whenBodiesDone(") + bodies + ")";
}
}
});
diff --git a/core/camel-main/src/main/java/org/apache/camel/main/DefaultConfigurationConfigurer.java b/core/camel-main/src/main/java/org/apache/camel/main/DefaultConfigurationConfigurer.java
index 10a96b653bc..bceee6d6010 100644
--- a/core/camel-main/src/main/java/org/apache/camel/main/DefaultConfigurationConfigurer.java
+++ b/core/camel-main/src/main/java/org/apache/camel/main/DefaultConfigurationConfigurer.java
@@ -182,7 +182,8 @@ public final class DefaultConfigurationConfigurer {
camelContext.getInflightRepository().setInflightBrowseEnabled(config.isInflightRepositoryBrowseEnabled());
if (config.getLogDebugMaxChars() != 0) {
- camelContext.getGlobalOptions().put(Exchange.LOG_DEBUG_BODY_MAX_CHARS, "" + config.getLogDebugMaxChars());
+ camelContext.getGlobalOptions().put(Exchange.LOG_DEBUG_BODY_MAX_CHARS,
+ Integer.toString(config.getLogDebugMaxChars()));
}
// stream caching
diff --git a/core/camel-management/src/main/java/org/apache/camel/management/mbean/LoadThroughput.java b/core/camel-management/src/main/java/org/apache/camel/management/mbean/LoadThroughput.java
index e30e0c05496..dd05d4595d8 100644
--- a/core/camel-management/src/main/java/org/apache/camel/management/mbean/LoadThroughput.java
+++ b/core/camel-management/src/main/java/org/apache/camel/management/mbean/LoadThroughput.java
@@ -64,7 +64,7 @@ public final class LoadThroughput {
@Override
public String toString() {
- return "" + thp;
+ return Double.toString(thp);
}
}
diff --git a/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedAsyncProcessorAwaitManager.java b/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedAsyncProcessorAwaitManager.java
index aefffec1fcf..66d8aaba4b5 100644
--- a/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedAsyncProcessorAwaitManager.java
+++ b/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedAsyncProcessorAwaitManager.java
@@ -70,12 +70,12 @@ public class ManagedAsyncProcessorAwaitManager extends ManagedService implements
Collection<AsyncProcessorAwaitManager.AwaitThread> threads = manager.browse();
for (AsyncProcessorAwaitManager.AwaitThread entry : threads) {
CompositeType ct = CamelOpenMBeanTypes.listAwaitThreadsCompositeType();
- String id = "" + entry.getBlockedThread().getId();
+ String id = Long.toString(entry.getBlockedThread().getId());
String name = entry.getBlockedThread().getName();
String exchangeId = entry.getExchange().getExchangeId();
String routeId = entry.getRouteId();
String nodeId = entry.getNodeId();
- String duration = "" + entry.getWaitDuration();
+ String duration = Long.toString(entry.getWaitDuration());
CompositeData data = new CompositeDataSupport(
ct,
diff --git a/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedInflightRepository.java b/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedInflightRepository.java
index 0a453b5d51d..7e6d660950c 100644
--- a/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedInflightRepository.java
+++ b/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedInflightRepository.java
@@ -86,8 +86,8 @@ public class ManagedInflightRepository extends ManagedService implements Managed
String fromRouteId = entry.getFromRouteId();
String atRouteId = entry.getAtRouteId();
String nodeId = entry.getNodeId();
- String elapsed = "" + entry.getElapsed();
- String duration = "" + entry.getDuration();
+ String elapsed = Long.toString(entry.getElapsed());
+ String duration = Long.toString(entry.getDuration());
CompositeData data = new CompositeDataSupport(
ct,
diff --git a/core/camel-management/src/main/java/org/apache/camel/management/mbean/RouteCoverageXmlParser.java b/core/camel-management/src/main/java/org/apache/camel/management/mbean/RouteCoverageXmlParser.java
index 6b5fde04442..52cfd1af7a7 100644
--- a/core/camel-management/src/main/java/org/apache/camel/management/mbean/RouteCoverageXmlParser.java
+++ b/core/camel-management/src/main/java/org/apache/camel/management/mbean/RouteCoverageXmlParser.java
@@ -117,9 +117,9 @@ public final class RouteCoverageXmlParser {
.getContextPlugin(ManagedCamelContext.class).getManagedRoute(id);
if (route != null) {
long total = route.getExchangesTotal();
- el.setAttribute("exchangesTotal", "" + total);
+ el.setAttribute("exchangesTotal", Long.toString(total));
long totalTime = route.getTotalProcessingTime();
- el.setAttribute("totalProcessingTime", "" + totalTime);
+ el.setAttribute("totalProcessingTime", Long.toString(totalTime));
}
} else if ("from".equals(qName)) {
// grab statistics from the parent route as from would be the same
@@ -131,9 +131,9 @@ public final class RouteCoverageXmlParser {
.getManagedRoute(routeId);
if (route != null) {
long total = route.getExchangesTotal();
- el.setAttribute("exchangesTotal", "" + total);
+ el.setAttribute("exchangesTotal", Long.toString(total));
long totalTime = route.getTotalProcessingTime();
- el.setAttribute("totalProcessingTime", "" + totalTime);
+ el.setAttribute("totalProcessingTime", Long.toString(totalTime));
// from is index-0
el.setAttribute("index", "0");
}
@@ -144,11 +144,11 @@ public final class RouteCoverageXmlParser {
.getManagedProcessor(id);
if (processor != null) {
long total = processor.getExchangesTotal();
- el.setAttribute("exchangesTotal", "" + total);
+ el.setAttribute("exchangesTotal", Long.toString(total));
long totalTime = processor.getTotalProcessingTime();
- el.setAttribute("totalProcessingTime", "" + totalTime);
+ el.setAttribute("totalProcessingTime", Long.toString(totalTime));
int index = processor.getIndex();
- el.setAttribute("index", "" + index);
+ el.setAttribute("index", Integer.toString(index));
}
}
} catch (Exception e) {
diff --git a/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticCounter.java b/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticCounter.java
index c0ec03f8a16..cf0b1a6914d 100644
--- a/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticCounter.java
+++ b/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticCounter.java
@@ -34,7 +34,7 @@ public class StatisticCounter extends Statistic {
@Override
public String toString() {
- return "" + value.get();
+ return Long.toString(value.get());
}
@Override
diff --git a/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticDelta.java b/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticDelta.java
index 4089d6ddde9..edbd18a18e5 100644
--- a/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticDelta.java
+++ b/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticDelta.java
@@ -36,7 +36,7 @@ public class StatisticDelta extends Statistic {
@Override
public String toString() {
- return "" + value.get();
+ return Long.toString(value.get());
}
@Override
diff --git a/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticMaximum.java b/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticMaximum.java
index 7ad332949e6..01aef94189f 100644
--- a/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticMaximum.java
+++ b/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticMaximum.java
@@ -46,7 +46,7 @@ public class StatisticMaximum extends Statistic {
@Override
public String toString() {
- return "" + value.get();
+ return Long.toString(value.get());
}
@Override
diff --git a/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticMinimum.java b/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticMinimum.java
index 677d343d6c1..3e7872a07c9 100644
--- a/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticMinimum.java
+++ b/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticMinimum.java
@@ -46,7 +46,7 @@ public class StatisticMinimum extends Statistic {
@Override
public String toString() {
- return "" + value.get();
+ return Long.toString(value.get());
}
@Override
diff --git a/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticValue.java b/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticValue.java
index 945c3c77809..1d4686b6f80 100644
--- a/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticValue.java
+++ b/core/camel-management/src/main/java/org/apache/camel/management/mbean/StatisticValue.java
@@ -34,7 +34,7 @@ public class StatisticValue extends Statistic {
@Override
public String toString() {
- return "" + value.get();
+ return Long.toString(value.get());
}
@Override
diff --git a/core/camel-support/src/main/java/org/apache/camel/support/builder/ExpressionBuilder.java b/core/camel-support/src/main/java/org/apache/camel/support/builder/ExpressionBuilder.java
index 78fddbd3fc0..70c57a4592f 100644
--- a/core/camel-support/src/main/java/org/apache/camel/support/builder/ExpressionBuilder.java
+++ b/core/camel-support/src/main/java/org/apache/camel/support/builder/ExpressionBuilder.java
@@ -734,7 +734,7 @@ public class ExpressionBuilder {
@Override
public String toString() {
- return "" + value;
+ return String.valueOf(value);
}
};
}
@@ -1238,7 +1238,7 @@ public class ExpressionBuilder {
@Override
public String toString() {
- return "" + expression;
+ return String.valueOf(expression);
}
};
}
@@ -1267,7 +1267,7 @@ public class ExpressionBuilder {
@Override
public String toString() {
- return "" + expression;
+ return String.valueOf(expression);
}
};
}
diff --git a/core/camel-support/src/main/java/org/apache/camel/support/builder/PredicateBuilder.java b/core/camel-support/src/main/java/org/apache/camel/support/builder/PredicateBuilder.java
index 7ce5fab0492..522bcc4d8ec 100644
--- a/core/camel-support/src/main/java/org/apache/camel/support/builder/PredicateBuilder.java
+++ b/core/camel-support/src/main/java/org/apache/camel/support/builder/PredicateBuilder.java
@@ -574,7 +574,7 @@ public class PredicateBuilder {
@Override
public String toString() {
- return "" + answer;
+ return String.valueOf(answer);
}
};
}
diff --git a/core/camel-support/src/main/java/org/apache/camel/support/builder/ValueBuilder.java b/core/camel-support/src/main/java/org/apache/camel/support/builder/ValueBuilder.java
index 8c6e91ebdce..7bad0ebf361 100644
--- a/core/camel-support/src/main/java/org/apache/camel/support/builder/ValueBuilder.java
+++ b/core/camel-support/src/main/java/org/apache/camel/support/builder/ValueBuilder.java
@@ -186,7 +186,7 @@ public class ValueBuilder implements Expression, Predicate {
}
public ValueBuilder tokenize(String token, int group, boolean skipFirst) {
- return tokenize(token, "" + group, skipFirst);
+ return tokenize(token, Integer.toString(group), skipFirst);
}
public ValueBuilder tokenize(String token, String group, boolean skipFirst) {
diff --git a/core/camel-util/src/main/java/org/apache/camel/util/FileUtil.java b/core/camel-util/src/main/java/org/apache/camel/util/FileUtil.java
index 809edd7eef0..22a6db39253 100644
--- a/core/camel-util/src/main/java/org/apache/camel/util/FileUtil.java
+++ b/core/camel-util/src/main/java/org/apache/camel/util/FileUtil.java
@@ -270,7 +270,7 @@ public final class FileUtil {
* {@link java.io.File#separator}).
*/
public static String compactPath(String path) {
- return compactPath(path, "" + File.separatorChar);
+ return compactPath(path, String.valueOf(File.separatorChar));
}
/**
@@ -278,7 +278,7 @@ public final class FileUtil {
*
*/
public static String compactPath(String path, char separator) {
- return compactPath(path, "" + separator);
+ return compactPath(path, String.valueOf(separator));
}
/**
diff --git a/core/camel-util/src/main/java/org/apache/camel/util/StringHelper.java b/core/camel-util/src/main/java/org/apache/camel/util/StringHelper.java
index af2e99818f9..b3d44e3920c 100644
--- a/core/camel-util/src/main/java/org/apache/camel/util/StringHelper.java
+++ b/core/camel-util/src/main/java/org/apache/camel/util/StringHelper.java
@@ -924,7 +924,7 @@ public final class StringHelper {
return bytes + " B";
}
int exp = (int) (Math.log(bytes) / Math.log(unit));
- String pre = "KMGTPE".charAt(exp - 1) + "";
+ String pre = String.valueOf("KMGTPE".charAt(exp - 1));
return String.format(locale, "%.1f %sB", bytes / Math.pow(unit, exp), pre);
}
diff --git a/core/camel-util/src/main/java/org/apache/camel/util/UnitUtils.java b/core/camel-util/src/main/java/org/apache/camel/util/UnitUtils.java
index 5265d710c35..40ca7a53635 100644
--- a/core/camel-util/src/main/java/org/apache/camel/util/UnitUtils.java
+++ b/core/camel-util/src/main/java/org/apache/camel/util/UnitUtils.java
@@ -43,7 +43,7 @@ public final class UnitUtils {
return bytes + " B";
}
int exp = (int) (Math.log(bytes) / Math.log(unit));
- String pre = "" + "kMGTPE".charAt(exp - 1);
+ String pre = String.valueOf("kMGTPE".charAt(exp - 1));
return String.format("%.1f %sB", bytes / Math.pow(unit, exp), pre);
}
@@ -75,7 +75,7 @@ public final class UnitUtils {
return bytes + " B";
}
int exp = (int) (Math.log(bytes) / Math.log(unit));
- String pre = "" + "kMGTPE".charAt(exp - 1);
+ String pre = String.valueOf("kMGTPE".charAt(exp - 1));
String answer = String.format("%.1f %sB", bytes / Math.pow(unit, exp), pre);
char sep = DecimalFormatSymbols.getInstance().getDecimalSeparator();
diff --git a/core/camel-xml-io/src/main/java/org/apache/camel/xml/io/MXParser.java b/core/camel-xml-io/src/main/java/org/apache/camel/xml/io/MXParser.java
index fe086e2cdec..c7b77cc684b 100644
--- a/core/camel-xml-io/src/main/java/org/apache/camel/xml/io/MXParser.java
+++ b/core/camel-xml-io/src/main/java/org/apache/camel/xml/io/MXParser.java
@@ -3093,7 +3093,7 @@ public class MXParser implements XmlPullParser {
if (ch > 127 || ch < 32) {
return "\\u" + Integer.toHexString((int)ch);
}
- return "" + ch;
+ return String.valueOf(ch);
}
protected String printable(String s) {
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelLogAction.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelLogAction.java
index 5cd8d987728..28e21302fdf 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelLogAction.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelLogAction.java
@@ -190,7 +190,7 @@ public class CamelLogAction extends ActionBaseCommand {
JsonObject root = loadStatus(ph.pid());
if (root != null) {
Row row = new Row();
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
JsonObject context = (JsonObject) root.get("context");
if (context == null) {
return;
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelThreadDump.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelThreadDump.java
index be551e12c61..20d0a866592 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelThreadDump.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelThreadDump.java
@@ -166,7 +166,7 @@ public class CamelThreadDump extends ActionWatchCommand {
protected void singleTable(List<Row> rows) {
System.out.println(AsciiTable.getTable(AsciiTable.NO_BORDERS, rows, Arrays.asList(
- new Column().header("ID").headerAlign(HorizontalAlign.CENTER).with(r -> "" + r.id),
+ new Column().header("ID").headerAlign(HorizontalAlign.CENTER).with(r -> Long.toString(r.id)),
new Column().header("NAME").dataAlign(HorizontalAlign.LEFT).maxWidth(60, OverflowBehaviour.ELLIPSIS_RIGHT)
.with(r -> r.name),
new Column().header("STATE").headerAlign(HorizontalAlign.RIGHT).with(r -> r.state),
@@ -179,7 +179,7 @@ public class CamelThreadDump extends ActionWatchCommand {
protected void tableAndStackTrace(List<Row> rows) {
for (Row row : rows) {
System.out.println(AsciiTable.getTable(AsciiTable.NO_BORDERS, List.of(row), Arrays.asList(
- new Column().header("ID").headerAlign(HorizontalAlign.CENTER).with(r -> "" + r.id),
+ new Column().header("ID").headerAlign(HorizontalAlign.CENTER).with(r -> Long.toString(r.id)),
new Column().header("NAME").dataAlign(HorizontalAlign.LEFT).maxWidth(60, OverflowBehaviour.ELLIPSIS_RIGHT)
.with(r -> r.name),
new Column().header("STATE").headerAlign(HorizontalAlign.RIGHT).with(r -> r.state),
@@ -235,7 +235,7 @@ public class CamelThreadDump extends ActionWatchCommand {
if (r.blockedTime > 0) {
return r.blocked + "(" + r.blockedTime + "ms)";
} else {
- return "" + r.blocked;
+ return Long.toString(r.blocked);
}
}
@@ -243,7 +243,7 @@ public class CamelThreadDump extends ActionWatchCommand {
if (r.waitedTime > 0) {
return r.waited + "(" + r.waitedTime + "ms)";
} else {
- return "" + r.waited;
+ return Long.toString(r.waited);
}
}
@@ -251,7 +251,7 @@ public class CamelThreadDump extends ActionWatchCommand {
if (r.stackTrace == null || r.stackTrace.isEmpty()) {
return "";
}
- return "" + r.stackTrace.get(0);
+ return r.stackTrace.get(0);
}
private static class Row {
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelTraceAction.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelTraceAction.java
index ccd06bf705c..97de403abc0 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelTraceAction.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelTraceAction.java
@@ -302,7 +302,7 @@ public class CamelTraceAction extends ActionBaseCommand {
JsonObject root = loadStatus(ph.pid());
if (root != null) {
Pid row = new Pid();
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
JsonObject context = (JsonObject) root.get("context");
if (context == null) {
return;
@@ -853,7 +853,7 @@ public class CamelTraceAction extends ActionBaseCommand {
} else if (r.last) {
return "*<--";
} else {
- return "" + r.nodeId;
+ return r.nodeId;
}
}
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/LoggerAction.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/LoggerAction.java
index 6a688a98d1e..5b4c3a23947 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/LoggerAction.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/LoggerAction.java
@@ -101,7 +101,7 @@ public class LoggerAction extends ActionBaseCommand {
JsonObject root = loadStatus(ph.pid());
if (root != null) {
Row row = new Row();
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
row.uptime = extractSince(ph);
row.ago = TimeUtils.printSince(row.uptime);
JsonObject context = (JsonObject) root.get("context");
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/RouteControllerAction.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/RouteControllerAction.java
index a00cfa6e1e5..f54c75ed57c 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/RouteControllerAction.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/RouteControllerAction.java
@@ -271,7 +271,7 @@ public class RouteControllerAction extends ActionWatchCommand {
protected String getAttempts(Row r) {
if (r.supervising != null) {
- return "" + r.attempts;
+ return Long.toString(r.attempts);
}
return "";
}
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelContextStatus.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelContextStatus.java
index 0013baab569..2adb6813819 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelContextStatus.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelContextStatus.java
@@ -69,7 +69,7 @@ public class CamelContextStatus extends ProcessWatchCommand {
if ("CamelJBang".equals(row.name)) {
row.name = ProcessHelper.extractName(root, ph);
}
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
row.uptime = extractSince(ph);
row.age = TimeUtils.printSince(row.uptime);
JsonObject runtime = (JsonObject) root.get("runtime");
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelContextTop.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelContextTop.java
index 6a3c791a5ae..c85d2705d9f 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelContextTop.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelContextTop.java
@@ -81,7 +81,7 @@ public class CamelContextTop extends ProcessWatchCommand {
if ("CamelJBang".equals(row.name)) {
row.name = ProcessHelper.extractName(root, ph);
}
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
row.uptime = extractSince(ph);
row.ago = TimeUtils.printSince(row.uptime);
JsonObject runtime = (JsonObject) root.get("runtime");
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelCount.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelCount.java
index 6474d564924..94f65b280cf 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelCount.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelCount.java
@@ -76,7 +76,7 @@ public class CamelCount extends ProcessWatchCommand {
if ("CamelJBang".equals(row.name)) {
row.name = ProcessHelper.extractName(root, ph);
}
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
row.age = TimeUtils.printSince(extractSince(ph));
Map<String, ?> stats = context.getMap("statistics");
if (stats != null) {
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelProcessorStatus.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelProcessorStatus.java
index 801c0819a68..4ccdc11ba39 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelProcessorStatus.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelProcessorStatus.java
@@ -95,7 +95,7 @@ public class CamelProcessorStatus extends ProcessWatchCommand {
if ("CamelJBang".equals(row.name)) {
row.name = ProcessHelper.extractName(root, ph);
}
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
row.routeId = o.getString("routeId");
row.processor = o.getString("from");
row.source = o.getString("source");
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelRouteStatus.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelRouteStatus.java
index 20af013fd3a..fb18e08d512 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelRouteStatus.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/CamelRouteStatus.java
@@ -86,7 +86,7 @@ public class CamelRouteStatus extends ProcessWatchCommand {
if ("CamelJBang".equals(row.name)) {
row.name = ProcessHelper.extractName(root, ph);
}
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
row.routeId = o.getString("routeId");
row.from = o.getString("from");
row.source = o.getString("source");
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/Hawtio.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/Hawtio.java
index eef249b6a58..f85b33d26c6 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/Hawtio.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/Hawtio.java
@@ -85,7 +85,7 @@ public class Hawtio extends CamelCommand {
protected void disconnectJolokia() throws Exception {
Jolokia jolokia = new Jolokia(getMain());
- jolokia.name = "" + pid;
+ jolokia.name = Long.toString(pid);
jolokia.stop = true;
jolokia.call();
}
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/Jolokia.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/Jolokia.java
index c5eb4cd9c59..1c9f580fef7 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/Jolokia.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/Jolokia.java
@@ -58,11 +58,11 @@ public class Jolokia extends ProcessBaseCommand {
try {
OptionsAndArgs options;
if (stop) {
- options = new OptionsAndArgs(null, "stop", "" + pid);
+ options = new OptionsAndArgs(null, "stop", Long.toString(pid));
} else {
// find a new free port to use when starting a new connection
long port = AvailablePortFinder.getNextAvailable(8778, 10000);
- options = new OptionsAndArgs(null, "--port", "" + port, "start", "" + pid);
+ options = new OptionsAndArgs(null, "--port", Long.toString(port), "start", Long.toString(pid));
}
VirtualMachineHandlerOperations vmHandler = PlatformUtils.createVMAccess(options);
CommandDispatcher dispatcher = new CommandDispatcher(options);
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListBlocked.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListBlocked.java
index 0e962d6add3..fad70f55e59 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListBlocked.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListBlocked.java
@@ -68,7 +68,7 @@ public class ListBlocked extends ProcessWatchCommand {
if ("CamelJBang".equals(row.name)) {
row.name = ProcessHelper.extractName(root, ph);
}
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
row.uptime = extractSince(ph);
row.age = TimeUtils.printSince(row.uptime);
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListCircuitBreaker.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListCircuitBreaker.java
index 9a7501f03a9..1d27e4c249d 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListCircuitBreaker.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListCircuitBreaker.java
@@ -68,7 +68,7 @@ public class ListCircuitBreaker extends ProcessWatchCommand {
if ("CamelJBang".equals(row.name)) {
row.name = ProcessHelper.extractName(root, ph);
}
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
row.uptime = extractSince(ph);
row.age = TimeUtils.printSince(row.uptime);
Row baseRow = row.copy();
@@ -161,27 +161,27 @@ public class ListCircuitBreaker extends ProcessWatchCommand {
} else if (r.failureRate > 0) {
return +r.failedCalls + " (" + String.format("%.0f", r.failureRate) + "%)";
} else {
- return "" + r.failedCalls;
+ return Integer.toString(r.failedCalls);
}
}
private String getPending(Row r) {
if ("resilience4j".equals(r.component)) {
- return "" + r.bufferedCalls;
+ return Integer.toString(r.bufferedCalls);
}
return "";
}
private String getSuccess(Row r) {
if ("resilience4j".equals(r.component)) {
- return "" + r.successfulCalls;
+ return Integer.toString(r.successfulCalls);
}
return "";
}
private String getReject(Row r) {
if ("resilience4j".equals(r.component)) {
- return "" + r.notPermittedCalls;
+ return Long.toString(r.notPermittedCalls);
}
return "";
}
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListEndpoint.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListEndpoint.java
index a74437d66e7..7ae927c6221 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListEndpoint.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListEndpoint.java
@@ -106,7 +106,7 @@ public class ListEndpoint extends ProcessWatchCommand {
if ("CamelJBang".equals(row.name)) {
row.name = ProcessHelper.extractName(root, ph);
}
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
row.endpoint = o.getString("uri");
row.direction = o.getString("direction");
row.total = o.getString("hits");
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListEvent.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListEvent.java
index 04b950d1740..12373e958f4 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListEvent.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListEvent.java
@@ -72,7 +72,7 @@ public class ListEvent extends ProcessWatchCommand {
if ("CamelJBang".equals(row.name)) {
row.name = ProcessHelper.extractName(root, ph);
}
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
if (filter == null || filter.contains("context")) {
fetchEvents(root, row, "events", rows);
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListHealth.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListHealth.java
index c8d00e72319..8af0c91103d 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListHealth.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListHealth.java
@@ -102,7 +102,7 @@ public class ListHealth extends ProcessWatchCommand {
for (int i = 0; i < array.size(); i++) {
JsonObject o = (JsonObject) array.get(i);
Row row = new Row();
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
row.uptime = extractSince(ph);
row.ago = TimeUtils.printSince(row.uptime);
row.name = context.getString("name");
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListInflight.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListInflight.java
index 77c0346072a..d67bc561908 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListInflight.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListInflight.java
@@ -68,7 +68,7 @@ public class ListInflight extends ProcessWatchCommand {
if ("CamelJBang".equals(row.name)) {
row.name = ProcessHelper.extractName(root, ph);
}
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
row.uptime = extractSince(ph);
row.age = TimeUtils.printSince(row.uptime);
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListMetric.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListMetric.java
index 119978d95a1..c21de371038 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListMetric.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListMetric.java
@@ -80,7 +80,7 @@ public class ListMetric extends ProcessWatchCommand {
if ("CamelJBang".equals(row.name)) {
row.name = ProcessHelper.extractName(root, ph);
}
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
row.uptime = extractSince(ph);
row.age = TimeUtils.printSince(row.uptime);
Row baseRow = row.copy();
@@ -244,7 +244,7 @@ public class ListMetric extends ProcessWatchCommand {
}
private String getNumber(double d) {
- String s = "" + d;
+ String s = Double.toString(d);
if (s.equals("0.0") || s.equals("0,0")) {
return "";
} else if (s.endsWith(".0") || s.endsWith(",0")) {
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListProcess.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListProcess.java
index 97649815e61..04749185668 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListProcess.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListProcess.java
@@ -57,7 +57,7 @@ public class ListProcess extends ProcessWatchCommand {
JsonObject root = loadStatus(ph.pid());
if (root != null) {
Row row = new Row();
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
row.uptime = extractSince(ph);
row.ago = TimeUtils.printSince(row.uptime);
JsonObject context = (JsonObject) root.get("context");
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListService.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListService.java
index 4500cee432b..d3861d6501b 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListService.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListService.java
@@ -68,7 +68,7 @@ public class ListService extends ProcessWatchCommand {
if ("CamelJBang".equals(row.name)) {
row.name = ProcessHelper.extractName(root, ph);
}
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
row.uptime = extractSince(ph);
row.age = TimeUtils.printSince(row.uptime);
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListVault.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListVault.java
index b5c3fe4393d..0c3d149e5d7 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListVault.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ListVault.java
@@ -68,7 +68,7 @@ public class ListVault extends ProcessWatchCommand {
JsonObject root = loadStatus(ph.pid());
if (root != null) {
Row row = new Row();
- row.pid = "" + ph.pid();
+ row.pid = Long.toString(ph.pid());
JsonObject context = (JsonObject) root.get("context");
if (context == null) {
return;
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/StopProcess.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/StopProcess.java
index e0136475fd1..0365b186a63 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/StopProcess.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/StopProcess.java
@@ -56,7 +56,7 @@ public class StopProcess extends ProcessBaseCommand {
// stop by deleting the pid file
for (Long pid : pids) {
File dir = new File(System.getProperty("user.home"), ".camel");
- File pidFile = new File(dir, "" + pid);
+ File pidFile = new File(dir, Long.toString(pid));
if (pidFile.exists()) {
System.out.println("Shutting down Camel integration (PID: " + pid + ")");
FileUtil.deleteFile(pidFile);
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/common/RuntimeUtil.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/common/RuntimeUtil.java
index 1166769d5b4..6153364580f 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/common/RuntimeUtil.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/common/RuntimeUtil.java
@@ -36,7 +36,7 @@ public final class RuntimeUtil {
String level, boolean color, boolean json, boolean pipe, boolean export) {
if (INIT_DONE.compareAndSet(false, true)) {
long pid = ProcessHandle.current().pid();
- System.setProperty("pid", "" + pid);
+ System.setProperty("pid", Long.toString(pid));
if (export) {
Configurator.initialize("CamelJBang", "log4j2-export.properties");
diff --git a/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/http/VertxHttpServer.java b/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/http/VertxHttpServer.java
index 6f274e66eaf..b6205775d51 100644
--- a/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/http/VertxHttpServer.java
+++ b/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/http/VertxHttpServer.java
@@ -92,7 +92,7 @@ public final class VertxHttpServer {
private static void doRegisterServer(CamelContext camelContext, int port, boolean stub) {
// need to capture we use http-server
- CamelJBangSettingsHelper.writeSettings("camel.jbang.platform-http.port", "" + port);
+ CamelJBangSettingsHelper.writeSettings("camel.jbang.platform-http.port", Integer.toString(port));
if (stub) {
return;