You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by csivaguru <gi...@git.apache.org> on 2016/06/23 02:02:07 UTC
[GitHub] storm pull request #1512: Adding hdfs-conf.yaml to all test cases to support...
GitHub user csivaguru opened a pull request:
https://github.com/apache/storm/pull/1512
Adding hdfs-conf.yaml to all test cases to support security.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/csivaguru/storm STORM-1924
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1512.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1512
----
commit 7eb7cc1a204ab0a30e9be9c4db8b546c029feb23
Author: Parth Brahmbhatt <br...@gmail.com>
Date: 2014-10-23T16:52:14Z
Adding hdfs-conf.yaml to all test cases to support security.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1512: Adding hdfs-conf.yaml to all test cases to support securi...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1512
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1512: Adding hdfs-conf.yaml to all test cases to support securi...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1512
+1 once my comments are addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1512: Adding hdfs-conf.yaml to all test cases to support...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1512#discussion_r68336156
--- Diff: external/storm-hdfs/src/test/java/org/apache/storm/hdfs/trident/TridentFileTopology.java ---
@@ -75,14 +78,20 @@ public static StormTopology buildTopology(String hdfsUrl){
public static void main(String[] args) throws Exception {
Config conf = new Config();
conf.setMaxSpoutPending(5);
- if (args.length == 1) {
+
+ Yaml yaml = new Yaml();
+ InputStream in = new FileInputStream(args[1]);
+ Map<String, Object> yamlConf = (Map<String, Object>) yaml.load(in);
+ in.close();
+ conf.put("hdfs.config", yamlConf);
+
+ if (args.length == 2) {
LocalCluster cluster = new LocalCluster();
cluster.submitTopology("wordCounter", conf, buildTopology(args[0]));
Thread.sleep(120 * 1000);
- }
- else if(args.length == 2) {
+ } else if(args.length == 3) {
conf.setNumWorkers(3);
- StormSubmitter.submitTopology(args[1], conf, buildTopology(args[0]));
+ StormSubmitter.submitTopology(args[2], conf, buildTopology(args[0]));
} else{
System.out.println("Usage: TridentFileTopology <hdfs url> [topology name]");
--- End diff --
@csivaguru You need to update usage here as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1512: Adding hdfs-conf.yaml to all test cases to support securi...
Posted by csivaguru <gi...@git.apache.org>.
Github user csivaguru commented on the issue:
https://github.com/apache/storm/pull/1512
Can this be merged in? @harshach @HeartSaVioR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1512: Adding hdfs-conf.yaml to all test cases to support...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1512#discussion_r68336175
--- Diff: external/storm-hdfs/src/test/java/org/apache/storm/hdfs/trident/TridentSequenceTopology.java ---
@@ -73,14 +75,20 @@ public static StormTopology buildTopology(String hdfsUrl){
public static void main(String[] args) throws Exception {
Config conf = new Config();
conf.setMaxSpoutPending(5);
- if (args.length == 1) {
+
+ Yaml yaml = new Yaml();
+ InputStream in = new FileInputStream(args[1]);
+ Map<String, Object> yamlConf = (Map<String, Object>) yaml.load(in);
+ in.close();
+ conf.put("hdfs.config", yamlConf);
+
+ if (args.length == 2) {
LocalCluster cluster = new LocalCluster();
cluster.submitTopology("wordCounter", conf, buildTopology(args[0]));
Thread.sleep(120 * 1000);
- }
- else if(args.length == 2) {
+ } else if(args.length == 3) {
conf.setNumWorkers(3);
- StormSubmitter.submitTopology(args[1], conf, buildTopology(args[0]));
+ StormSubmitter.submitTopology(args[2], conf, buildTopology(args[0]));
} else{
System.out.println("Usage: TridentFileTopology <hdfs url> [topology name]");
--- End diff --
@csivaguru same here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1512: Adding hdfs-conf.yaml to all test cases to support securi...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1512
+1 Thanks @csivaguru.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---