[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #4422: [Feature][Transform] Add CatalogTable support for FilterFieldTransform

["Hisoka-X (via GitHub)" <gi...@apache.org>]

Hisoka-X commented on code in PR #4422:
URL: https://github.com/apache/incubator-seatunnel/pull/4422#discussion_r1149949288


##########
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/exception/FilterFieldTransformErrorCode.java:
##########
@@ -15,25 +15,28 @@
  * limitations under the License.
  */
 
-package org.apache.seatunnel.transform;
+package org.apache.seatunnel.transform.exception;
 
-import org.apache.seatunnel.api.configuration.util.OptionRule;
-import org.apache.seatunnel.api.table.factory.Factory;
-import org.apache.seatunnel.api.table.factory.TableTransformFactory;
+import org.apache.seatunnel.common.exception.SeaTunnelErrorCode;
 
-import com.google.auto.service.AutoService;
+public enum FilterFieldTransformErrorCode implements SeaTunnelErrorCode {
+    FILTER_FIELD_NOT_FOUND("FILTER_FIELD_TRANSFORM-01", "filter filed not found");

Review Comment:
   ```suggestion
       FILTER_FIELD_NOT_FOUND("FILTER_FIELD_TRANSFORM-01", "filter field not found");
   ```



##########
docs/en/connector-v2/Error-Quick-Reference-Manual.md:
##########
@@ -246,3 +246,9 @@ problems encountered by users.
 |---------------|---------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
 | S3RedShift-01 | Aggregate committer error | S3Redshift Sink Connector will write data to s3 and then move file to the target s3 path. And then use `Copy` action copy the data to Redshift. Please check the error log and find out the specific reason. |
 
+## FilterFieldTransform Error Codes
+
+|           code            |      description       |        solution         |
+|---------------------------|------------------------|-------------------------|
+| FILTER_FIELD_TRANSFORM-01 | filter filed not found | filter filed not found. |

Review Comment:
   ```suggestion
   | FILTER_FIELD_TRANSFORM-01 | filter field not found | filter field not found. |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org