[GitHub] [mynewt-mcumgr] de-nordic commented on issue #62: [DNM] samples/smp_svr: Update of Zephyr sample

[GitBox <gi...@apache.org>]

de-nordic commented on issue #62: [DNM] samples/smp_svr: Update of Zephyr sample
URL: https://github.com/apache/mynewt-mcumgr/pull/62#issuecomment-579224900
 
 
   > 
   > 
   > @de-nordic Doing a tree diff between current `smp_svr` in Zephyr and this PR, I see two differences:
   > 
   >     1. There is a `prj.conf.tiny` file here and not in Zephyr, should it be removed?
   > 
   >     2. There is a `sample.yaml` file in Zephyr that is not added here, should it be added?
   > 
   > 
   > Apart from those changes, everything looks fine.
   
   1) yes it should, that is my mistake
   2) it should be there; I have removed it because somehow I thought that there is no reason to include it to mynewt fork which is stupid, if we take into account that this should be exact sync of the sample from zephyr
   
   Thanks for reviewing.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services