You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Andrew Sherman (Code Review)" <ge...@cloudera.org> on 2019/05/21 00:20:19 UTC

[native-toolchain-CR] Patch Thrift to 0.9.3-p6 to eliminate erroneous ssl warnings. 

Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13383


Change subject: Patch Thrift to 0.9.3-p6 to eliminate erroneous ssl warnings.
......................................................................

Patch Thrift to 0.9.3-p6 to eliminate erroneous ssl warnings.

This will be used to fix "IMPALA-8333: Remove Impala Shell warnings
part 2".

Remove misleading deprecation warning from the TSSLSocket.validate
method. This method is used to determine if the peer's SSL certificate
should be validated. The deprecation warning message is a mistake,
probably as the result of a confusion of the role of the validate method
with the use of a deprecated parameter, also named validate, that is
used in the initializer. This code was removed in subsequent Thrift
releases.

TESTING:

I built the toolchain locally and using jenkins.
I built impala with the new toolchain and tested that IMPALA-8333 is
fixed.

Change-Id: I84c2de4e6e3b21a4e3a5591f469d47ab34101687
---
M buildall.sh
A source/thrift/thrift-0.9.3-patches/0006-remove-misleading-deprecation-warning.patch
2 files changed, 29 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/83/13383/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13383
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84c2de4e6e3b21a4e3a5591f469d47ab34101687
Gerrit-Change-Number: 13383
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>

[native-toolchain-CR] Patch Thrift to 0.9.3-p6 to eliminate erroneous ssl warnings.

Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13383 )

Change subject: Patch Thrift to 0.9.3-p6 to eliminate erroneous ssl warnings.
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13383
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2de4e6e3b21a4e3a5591f469d47ab34101687
Gerrit-Change-Number: 13383
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 May 2019 16:52:24 +0000
Gerrit-HasComments: No

[native-toolchain-CR] Patch Thrift to 0.9.3-p6 to eliminate erroneous ssl warnings.

Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13383 )

Change subject: Patch Thrift to 0.9.3-p6 to eliminate erroneous ssl warnings.
......................................................................

Patch Thrift to 0.9.3-p6 to eliminate erroneous ssl warnings.

This will be used to fix "IMPALA-8333: Remove Impala Shell warnings
part 2".

Remove misleading deprecation warning from the TSSLSocket.validate
method. This method is used to determine if the peer's SSL certificate
should be validated. The deprecation warning message is a mistake,
probably as the result of a confusion of the role of the validate method
with the use of a deprecated parameter, also named validate, that is
used in the initializer. This code was removed in subsequent Thrift
releases.

TESTING:

I built the toolchain locally and using jenkins.
I built impala with the new toolchain and tested that IMPALA-8333 is
fixed.

Change-Id: I84c2de4e6e3b21a4e3a5591f469d47ab34101687
Reviewed-on: http://gerrit.cloudera.org:8080/13383
Reviewed-by: Thomas Marshall <tm...@cloudera.com>
Tested-by: Thomas Marshall <tm...@cloudera.com>
---
M buildall.sh
A source/thrift/thrift-0.9.3-patches/0006-remove-misleading-deprecation-warning.patch
2 files changed, 29 insertions(+), 0 deletions(-)

Approvals:
  Thomas Marshall: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13383
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I84c2de4e6e3b21a4e3a5591f469d47ab34101687
Gerrit-Change-Number: 13383
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>

[native-toolchain-CR] Patch Thrift to 0.9.3-p6 to eliminate erroneous ssl warnings.

Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13383 )

Change subject: Patch Thrift to 0.9.3-p6 to eliminate erroneous ssl warnings.
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13383
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2de4e6e3b21a4e3a5591f469d47ab34101687
Gerrit-Change-Number: 13383
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 May 2019 18:03:40 +0000
Gerrit-HasComments: No