[GitHub] [dolphinscheduler] QuakeWang opened a new pull request, #10308: [Doc] Add how to use resource in shell task

[GitBox <gi...@apache.org>]

QuakeWang opened a new pull request, #10308:
URL: https://github.com/apache/dolphinscheduler/pull/10308

   close: #10222 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10308: [Doc] Add how to use resource in shell task

[GitBox <gi...@apache.org>]

zhongjiajie commented on code in PR #10308:
URL: https://github.com/apache/dolphinscheduler/pull/10308#discussion_r885158945


##########
docs/docs/zh/guide/task/shell.md:
##########
@@ -45,4 +44,6 @@ Shell 任务类型，用于创建 Shell 类型的任务并执行一系列的 She
 
 ## 注意事项
 
-Shell 任务类型通过解析任务日志是否包含 ```application_xxx_xxx``` 的内容来判断是否 Yarn 任务，如果是则会将相应的 ```application_id``` 的状态作为当前 Shell 节点的运行状态判断，此时如果操作停止工作流则会 Kill 相应的 ```application_id```
\ No newline at end of file
+Shell 任务类型通过解析任务日志是否包含 ```application_xxx_xxx``` 的内容来判断是否 Yarn 任务，如果是则会将相应的 ```application_id``` 的状态作为当前 Shell 节点的运行状态判断，此时如果操作停止工作流则会 Kill 相应的 ```application_id```
+
+如果 Shell 任务中需要使用到用户自定义的脚本，则可通过资源中心来上传对应的文件，可参考：[文件管理](../resource/file-manage.md)。

Review Comment:
   ```suggestion
   如果 Shell 任务中需要使用到用户自定义的脚本，可通过资源中心来上传对应的文件然后在 Shell 任务中引用他们，可参考：[文件管理](../resource/file-manage.md)。
   ```



##########
docs/docs/en/guide/task/shell.md:
##########
@@ -43,6 +43,9 @@ After running this example, we would see "param_val" print in the log.
 ![demo-shell-custom-param](/img/tasks/demo/shell_custom_param.jpg)
 
 ## Attention
+
 The shell task type resolves whether the task log contains ```application_xxx_xxx``` to determine whether is the yarn task. If so, the corresponding application
 will be use to judge the running state of the current shell node. At this time, if stops the operation of the workflow, the corresponding ```application_id```
-will be killed.
\ No newline at end of file
+will be killed.
+
+If you want to use resource files in Shell tasks, you can upload corresponding files through the resource center. Reference: [file-manage](../resource/file-manage.md).

Review Comment:
   ```suggestion
   If you want to use resource files in Shell tasks, you can upload corresponding files through the resource center and then use the resources in the Shell task. Reference: [file-manage](../resource/file-manage.md).
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie merged pull request #10308: [Doc] Add how to use resource in shell task

[GitBox <gi...@apache.org>]

zhongjiajie merged PR #10308:
URL: https://github.com/apache/dolphinscheduler/pull/10308


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org