You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@isis.apache.org by Martin Hesse <mw...@gmail.com> on 2017/12/26 07:50:01 UTC
After migrating from 1.14.0 to 1.15.1: collections all lazy
Hi,
after I migrated an existing project from 1.14.0 to 1.15.1 all my
collections which were previously rendered eagerly (defaultView="table" in
layout xml) are now hidden / lazy by default.
The layout xml has not been changed.
I also tried to set the default view to "table" directly in a
CollectionLayout annotation and also tried the deprecated EAGERLY render
type in the CollectionLayout, but it didn't change the behavior.
Any advice on where I could continue looking? This is kind of a show
stopper.
Thanks and regards
Martin
Re: After migrating from 1.14.0 to 1.15.1: collections all lazy
Posted by Martin Hesse <mw...@gmail.com>.
Hi Dan,
Good news: the current master fixes the issue.
An interim release is not an option unfortunately in my current
environment.
Seems I'm stuck.... :-(
> I think actually maybe 1.14.0 was also broken here.
release 1.14.0 works fine in this regard, the collections annotated with
defaultView="table" in layout.xml do render eagerly.
Thanks
On Tue, Dec 26, 2017 at 4:20 PM, Dan Haywood <da...@haywood-associates.co.uk>
wrote:
> I think actually maybe 1.14.0 was also broken here.
>
> The default view, if there is no annotation and nothing in .layout.xml, is
> meant to be "hidden". This replaces an earlier, now deprecated, annotation
> of @CollectionLayout(render=EAGERLY) (and before that
> @Render(type=EAGERLY)
> ).
>
> So, if you want collections to be opened by default, then you will need to
> add in the defaultView.
>
> We could, I suppose, have a configuration property which would provide the
> "default default", ie whether all un-annotated views should be shown as
> hidden or as table. If that appeals, please raise a ticket.
>
> With respect to a bug fix release, I don't want to do that because (perhaps
> despite appearances) 1.16.0 is pretty close to release, certainly want to
> get a release out for voting by the end of the year.
>
> Meantime, you can use the "interim-release.sh" script to create your own
> local build if you so wish.
>
> HTH
> Dan
>
> On Tue, 26 Dec 2017 at 09:01 Martin Hesse <mw...@gmail.com> wrote:
>
> > Hi Dan,
> >
> > The ISIS-1698 issue description says the collection's view always
> defaults
> > to "table", but in my case it always defaults to "hidden".
> >
> > The latter case seems more of a showstopper, we can't expect a user to
> > click on the "table" button of a collection for every single entity he is
> > looking at to create the appropriate hints in his session.
> >
> > I'll try to see if the fix for ISIS-1698 makes the problem go away.
> > If that is the case, would a bugfix release for 1.15.1 be reasonable?
> > 1.16.0 seems to be quite far away still and I want to move away from
> 1.14.0
> > if possible.
> >
> >
> > Cheers
> >
> >
> > On Tue, Dec 26, 2017 at 3:25 PM, Dan Haywood <
> dan@haywood-associates.co.uk
> > >
> > wrote:
> >
> > > Hi Martin,
> > >
> > > this is a known issue which is fixed [1] in the latest -SNAPSHOT.
> > Perhaps
> > > you could build from master to confirm that the issue is fixed there?
> > >
> > > thx
> > > Dan
> > >
> > > [1] https://issues.apache.org/jira/browse/ISIS-1698
> > >
> > > On Tue, 26 Dec 2017 at 07:50 Martin Hesse <mw...@gmail.com> wrote:
> > >
> > > > Hi,
> > > >
> > > > after I migrated an existing project from 1.14.0 to 1.15.1 all my
> > > > collections which were previously rendered eagerly
> (defaultView="table"
> > > in
> > > > layout xml) are now hidden / lazy by default.
> > > >
> > > > The layout xml has not been changed.
> > > >
> > > > I also tried to set the default view to "table" directly in a
> > > > CollectionLayout annotation and also tried the deprecated EAGERLY
> > render
> > > > type in the CollectionLayout, but it didn't change the behavior.
> > > >
> > > > Any advice on where I could continue looking? This is kind of a show
> > > > stopper.
> > > >
> > > > Thanks and regards
> > > > Martin
> > > >
> > >
> >
>
Re: After migrating from 1.14.0 to 1.15.1: collections all lazy
Posted by Dan Haywood <da...@haywood-associates.co.uk>.
I think actually maybe 1.14.0 was also broken here.
The default view, if there is no annotation and nothing in .layout.xml, is
meant to be "hidden". This replaces an earlier, now deprecated, annotation
of @CollectionLayout(render=EAGERLY) (and before that @Render(type=EAGERLY)
).
So, if you want collections to be opened by default, then you will need to
add in the defaultView.
We could, I suppose, have a configuration property which would provide the
"default default", ie whether all un-annotated views should be shown as
hidden or as table. If that appeals, please raise a ticket.
With respect to a bug fix release, I don't want to do that because (perhaps
despite appearances) 1.16.0 is pretty close to release, certainly want to
get a release out for voting by the end of the year.
Meantime, you can use the "interim-release.sh" script to create your own
local build if you so wish.
HTH
Dan
On Tue, 26 Dec 2017 at 09:01 Martin Hesse <mw...@gmail.com> wrote:
> Hi Dan,
>
> The ISIS-1698 issue description says the collection's view always defaults
> to "table", but in my case it always defaults to "hidden".
>
> The latter case seems more of a showstopper, we can't expect a user to
> click on the "table" button of a collection for every single entity he is
> looking at to create the appropriate hints in his session.
>
> I'll try to see if the fix for ISIS-1698 makes the problem go away.
> If that is the case, would a bugfix release for 1.15.1 be reasonable?
> 1.16.0 seems to be quite far away still and I want to move away from 1.14.0
> if possible.
>
>
> Cheers
>
>
> On Tue, Dec 26, 2017 at 3:25 PM, Dan Haywood <dan@haywood-associates.co.uk
> >
> wrote:
>
> > Hi Martin,
> >
> > this is a known issue which is fixed [1] in the latest -SNAPSHOT.
> Perhaps
> > you could build from master to confirm that the issue is fixed there?
> >
> > thx
> > Dan
> >
> > [1] https://issues.apache.org/jira/browse/ISIS-1698
> >
> > On Tue, 26 Dec 2017 at 07:50 Martin Hesse <mw...@gmail.com> wrote:
> >
> > > Hi,
> > >
> > > after I migrated an existing project from 1.14.0 to 1.15.1 all my
> > > collections which were previously rendered eagerly (defaultView="table"
> > in
> > > layout xml) are now hidden / lazy by default.
> > >
> > > The layout xml has not been changed.
> > >
> > > I also tried to set the default view to "table" directly in a
> > > CollectionLayout annotation and also tried the deprecated EAGERLY
> render
> > > type in the CollectionLayout, but it didn't change the behavior.
> > >
> > > Any advice on where I could continue looking? This is kind of a show
> > > stopper.
> > >
> > > Thanks and regards
> > > Martin
> > >
> >
>
Re: After migrating from 1.14.0 to 1.15.1: collections all lazy
Posted by Martin Hesse <mw...@gmail.com>.
Hi Dan,
The ISIS-1698 issue description says the collection's view always defaults
to "table", but in my case it always defaults to "hidden".
The latter case seems more of a showstopper, we can't expect a user to
click on the "table" button of a collection for every single entity he is
looking at to create the appropriate hints in his session.
I'll try to see if the fix for ISIS-1698 makes the problem go away.
If that is the case, would a bugfix release for 1.15.1 be reasonable?
1.16.0 seems to be quite far away still and I want to move away from 1.14.0
if possible.
Cheers
On Tue, Dec 26, 2017 at 3:25 PM, Dan Haywood <da...@haywood-associates.co.uk>
wrote:
> Hi Martin,
>
> this is a known issue which is fixed [1] in the latest -SNAPSHOT. Perhaps
> you could build from master to confirm that the issue is fixed there?
>
> thx
> Dan
>
> [1] https://issues.apache.org/jira/browse/ISIS-1698
>
> On Tue, 26 Dec 2017 at 07:50 Martin Hesse <mw...@gmail.com> wrote:
>
> > Hi,
> >
> > after I migrated an existing project from 1.14.0 to 1.15.1 all my
> > collections which were previously rendered eagerly (defaultView="table"
> in
> > layout xml) are now hidden / lazy by default.
> >
> > The layout xml has not been changed.
> >
> > I also tried to set the default view to "table" directly in a
> > CollectionLayout annotation and also tried the deprecated EAGERLY render
> > type in the CollectionLayout, but it didn't change the behavior.
> >
> > Any advice on where I could continue looking? This is kind of a show
> > stopper.
> >
> > Thanks and regards
> > Martin
> >
>
Re: After migrating from 1.14.0 to 1.15.1: collections all lazy
Posted by Dan Haywood <da...@haywood-associates.co.uk>.
Hi Martin,
this is a known issue which is fixed [1] in the latest -SNAPSHOT. Perhaps
you could build from master to confirm that the issue is fixed there?
thx
Dan
[1] https://issues.apache.org/jira/browse/ISIS-1698
On Tue, 26 Dec 2017 at 07:50 Martin Hesse <mw...@gmail.com> wrote:
> Hi,
>
> after I migrated an existing project from 1.14.0 to 1.15.1 all my
> collections which were previously rendered eagerly (defaultView="table" in
> layout xml) are now hidden / lazy by default.
>
> The layout xml has not been changed.
>
> I also tried to set the default view to "table" directly in a
> CollectionLayout annotation and also tried the deprecated EAGERLY render
> type in the CollectionLayout, but it didn't change the behavior.
>
> Any advice on where I could continue looking? This is kind of a show
> stopper.
>
> Thanks and regards
> Martin
>