You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/07/29 13:07:59 UTC
[GitHub] [avro] izemlyanskiy opened a new pull request, #1584: AVRO-3408: Schema evolution with logical types
izemlyanskiy opened a new pull request, #1584:
URL: https://github.com/apache/avro/pull/1584
Hello! Please take a look a PR for the issue https://issues.apache.org/jira/browse/AVRO-3408
I hope I fulfilled all PR requirements but feel free to point me out if I missed something.
Thank you in advance. I would love the read what does the community think about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1584: AVRO-3408: Schema evolution with logical types
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on PR #1584:
URL: https://github.com/apache/avro/pull/1584#issuecomment-1199266808
Close/reopen to check! :roll_eyes: I'm not sure why the "rerun jobs" button disappeared!
Note that the 1.11.1 RC is out, after that release, we should be WAY more reactive to attack all of these contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] izemlyanskiy commented on pull request #1584: AVRO-3408: Schema evolution with logical types
Posted by GitBox <gi...@apache.org>.
izemlyanskiy commented on PR #1584:
URL: https://github.com/apache/avro/pull/1584#issuecomment-1367586413
Hey, @RyanSkraba ! I hope you're having wonderful holidays
> I'm marking this as Request changes to make sure it doesn't get merged before consensus on the mailing list. Spec changes affect all the SDKs.
could you elaborate how to make changes to the spec? Shall I write a letter or communicate to someone?
Thank you.
Marry Christmas and happy New Year!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] izemlyanskiy commented on pull request #1584: AVRO-3408: Schema evolution with logical types
Posted by "izemlyanskiy (via GitHub)" <gi...@apache.org>.
izemlyanskiy commented on PR #1584:
URL: https://github.com/apache/avro/pull/1584#issuecomment-1432274765
Hello?
Don't want to whine out but it feels like you turn a blind eye to this issue....
if someone could help me with my questions above it would be marvelous!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1584: AVRO-3408: Schema evolution with logical types
Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1584:
URL: https://github.com/apache/avro/pull/1584#issuecomment-1127255509
Close/re-open to trigger the GHA checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba closed pull request #1584: AVRO-3408: Schema evolution with logical types
Posted by GitBox <gi...@apache.org>.
RyanSkraba closed pull request #1584: AVRO-3408: Schema evolution with logical types
URL: https://github.com/apache/avro/pull/1584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g closed pull request #1584: AVRO-3408: Schema evolution with logical types
Posted by GitBox <gi...@apache.org>.
martin-g closed pull request #1584: AVRO-3408: Schema evolution with logical types
URL: https://github.com/apache/avro/pull/1584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] izemlyanskiy commented on pull request #1584: AVRO-3408: Schema evolution with logical types
Posted by GitBox <gi...@apache.org>.
izemlyanskiy commented on PR #1584:
URL: https://github.com/apache/avro/pull/1584#issuecomment-1366837390
Hi @mrk-andreev !
Thank you for poking this PR, yes the pr is okay, and per my understanding it's waiting for a small spec change.
It's still unclear to me though how this process look like. Where is the spec source text and who is the person(s) who can push the button.
if someone can explain, I'm ready to make a change and communicate with the folks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] izemlyanskiy commented on pull request #1584: AVRO-3408: Schema evolution with logical types
Posted by GitBox <gi...@apache.org>.
izemlyanskiy commented on PR #1584:
URL: https://github.com/apache/avro/pull/1584#issuecomment-1198645799
hi! does anyone knows why did the build fail? It used to be green...
And good news everyone, I tested this patch on our production, it works and we successfully migrated from one version to another one with it. And it works for several month on our prod (even at this moment)
So, from bug point of view, it's kinda safe to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] mrk-andreev commented on pull request #1584: AVRO-3408: Schema evolution with logical types
Posted by GitBox <gi...@apache.org>.
mrk-andreev commented on PR #1584:
URL: https://github.com/apache/avro/pull/1584#issuecomment-1366738478
Any news? Is this PR still alive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1584: AVRO-3408: Schema evolution with logical types
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #1584:
URL: https://github.com/apache/avro/pull/1584#issuecomment-1432690630
The specification sources can be found at https://github.com/apache/avro/blob/master/doc/content/en/docs/%2B%2Bversion%2B%2B/Specification/_index.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org