[GitHub] [hadoop-ozone] hanishakoneru commented on a change in pull request #565: HDDS-3030. Key Rename should preserve the ObjectID.

[GitBox <gi...@apache.org>]

hanishakoneru commented on a change in pull request #565: HDDS-3030. Key Rename should preserve the ObjectID.
URL: https://github.com/apache/hadoop-ozone/pull/565#discussion_r381465806
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRenameRequest.java
 ##########
 @@ -210,15 +210,11 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
           throw new OMException("Key not found " + fromKey, KEY_NOT_FOUND);
         }
 
-        // Copy fromKeyValue into toKeyValue and set objectID and updateID to
-        // current transactionLogIndex
-        toKeyValue = fromKeyValue.copyObject(false);
-        toKeyValue.setObjectID(trxnLogIndex);
-        toKeyValue.setUpdateID(trxnLogIndex);
 
 Review comment:
   We should still set the UpdateID here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org