You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/03 13:31:34 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #15162: Better compatibility/diagnostics for arbitrary UID in docker image

potiuk commented on a change in pull request #15162:
URL: https://github.com/apache/airflow/pull/15162#discussion_r606665326



##########
File path: scripts/in_container/prod/entrypoint_prod.sh
##########
@@ -244,6 +243,47 @@ function exec_to_bash_or_python_command_if_specified() {
     fi
 }
 
+function check_uid_gid() {
+    if [[ $(id -g) == "0" ]]; then
+        return
+    fi
+    if [[ $(id -u) == "50000" ]]; then
+        >&2 echo

Review comment:
       I turned it into warning only if 'airflow' user is used and GID is not 0. This should be quite nice for the users:
   
   * existing helm charts will work
   * it's rather OK to run airflow with any GID as long as you are never going to use the arbitrary UID for already created directories
   * we clearly warn the users and they will see it in their log files that GID=0 is the "recommended" way.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org