You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/12 20:53:39 UTC
[GitHub] kristw commented on a change in pull request #5861: [SIP-6] removed
get_data for BigNumber
kristw commented on a change in pull request #5861: [SIP-6] removed get_data for BigNumber
URL: https://github.com/apache/incubator-superset/pull/5861#discussion_r217185064
##########
File path: superset/assets/src/visualizations/BigNumber/BigNumber.jsx
##########
@@ -26,7 +23,7 @@ const PROPORTION = {
TRENDLINE: 0.3,
};
-function renderTooltipFactory(formatValue) {
+export function renderTooltipFactory(formatValue) {
Review comment:
This was used only in this file. Not sure it is useful to export now. (ok to expert if there are other places using or unit test)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org