[GitHub] [accumulo] milleruntime commented on a change in pull request #2318: Expose running compaction in coordinator for the monitor

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #2318:
URL: https://github.com/apache/accumulo/pull/2318#discussion_r730856800



##########
File path: core/src/main/java/org/apache/accumulo/core/util/compaction/ExternalCompactionUtil.java
##########
@@ -191,20 +200,24 @@ private static ExternalCompactionId getRunningCompactionId(HostAndPort compactor
    *          server context
    * @return map of compactor and external compaction jobs
    */
-  public static Map<HostAndPort,TExternalCompactionJob>
+  public static Map<QueueAndHostAndPort,TExternalCompactionJob>
       getCompactionsRunningOnCompactors(ClientContext context) {
 
-    final List<Pair<HostAndPort,Future<TExternalCompactionJob>>> running = new ArrayList<>();
+    final List<Pair<QueueAndHostAndPort,Future<TExternalCompactionJob>>> running =
+        new ArrayList<>();

Review comment:
       This data structure is definitely complex enough where you could create a class. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org