[GitHub] [arrow] lidavidm commented on a change in pull request #7994: ARROW-9804: [FlightRPC] Flight auth redesign

[GitBox <gi...@apache.org>]

lidavidm commented on a change in pull request #7994:
URL: https://github.com/apache/arrow/pull/7994#discussion_r477591584



##########
File path: java/flight/flight-core/src/main/java/org/apache/arrow/flight/CallOptions.java
##########
@@ -56,7 +56,7 @@ public static CallOption timeout(long duration, TimeUnit unit) {
   /**
    * CallOptions specific to GRPC stubs.
    */
-  interface GrpcCallOption extends CallOption {
+  public interface GrpcCallOption extends CallOption {

Review comment:
       This can't be public in this module - it should have a public subinterface in flight-grpc.

##########
File path: java/flight/flight-core/src/main/java/org/apache/arrow/flight/CallContext.java
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.arrow.flight;
+
+/**
+ * Tracks variables about the current request.
+ */
+public interface CallContext {

Review comment:
       Let's try not to rename existing classes unnecessarily and instead come up with new names. 

##########
File path: java/flight/flight-core/src/main/java/org/apache/arrow/flight/FlightRuntimeException.java
##########
@@ -29,7 +29,7 @@
   /**
    * Create a new exception from the given status.
    */
-  FlightRuntimeException(CallStatus status) {
+  public FlightRuntimeException(CallStatus status) {

Review comment:
       This shouldn't need to be public, a CallStatus has a toRuntimeException method already




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org