[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

[miguelaferreira <gi...@git.apache.org>]

Github user miguelaferreira commented on the pull request:

    https://github.com/apache/cloudstack/pull/935#issuecomment-155396401
  
    @nvazquez I've built and tested your PR in our environment and the functionality we have tests for remains stable. :+1: 
    
    What I did:
    
    1. build and unit-test with developer and systemvm profiles
    
    2. package centos7 KVM agent RPMs
    
    3. deploy infra with
    
       - 1 mangement server (war installed from step 1)
       - 2 NSX controllers (cluster)
       - 1 NSX manger node
       - 1 NSX service node
       - 1 KVM host (agent installed from step 2)
    
    4. deploy data center using [this](https://github.com/schubergphilis/MCT-shared/blob/master/marvin/mct-zone1-kvm1-NVP.cfg) config
    
    5. run marvin tests from `test/integration/smoke/test_nicira_controller.py` with flags `tags=advanced,required_hardware=true`
    
    Result
    ```
    [root@cs1 cloudstack]# nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-kvm1-NVP.cfg -s -a tags=advanced,required_hardware=true test/integration/smoke/test_nicira_controller.py
    
    ==== Marvin Init Started ====
    
    === Marvin Parse Config Successful ===
    
    === Marvin Setting TestData Successful===
    
    ==== Log Folder Path: /tmp//MarvinLogs//Nov_10_2015_10_27_55_46U497. All logs will be available here ====
    
    === Marvin Init Logging Successful===
    
    ==== Marvin Init Successful ====
    /usr/lib/python2.7/site-packages/requests/packages/urllib3/util/ssl_.py:100: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
      InsecurePlatformWarning
    (previous warning repeated a couple times)
    === TestName: test_01_nicira_controller | Status : SUCCESS ===
    
    === TestName: test_02_nicira_controller_redirect | Status : SUCCESS ===
    
    ===final results are now copied to: /tmp//MarvinLogs/test_nicira_controller_RV74VA===
    
    ```
    
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---