You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/08/27 15:23:08 UTC
[GitHub] [nifi] humpfhumpf opened a new pull request #4496: NIFI-7771: Infinite loop on WebUI when node stopped in cluster (PB1)
humpfhumpf opened a new pull request #4496:
URL: https://github.com/apache/nifi/pull/4496
#### Description of PR
This resolves "Problem 1" described in issue NIFI-7771.
The priority could then be changed to Important instead of Critical.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mtien-apache commented on pull request #4496: NIFI-7771: Infinite loop on WebUI when node stopped in cluster (PB1)
Posted by GitBox <gi...@apache.org>.
mtien-apache commented on pull request #4496:
URL: https://github.com/apache/nifi/pull/4496#issuecomment-729310428
@humpfhumpf LGTM +1. I have reviewed the PR and was able to reproduce the issue. After implementing your changes, I confirmed when using a load balancer and the selected nifi instance is shut down, infinite login looping no longer occurs on the UI. The JWT is removed and a new JWT is issued upon successful login. This was tested using OIDC login with Google and Microsoft Azure as Identity Providers. I also confirmed that regular LDAP authentication still works as expected. Thanks for your PR!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog closed pull request #4496: NIFI-7771: Infinite loop on WebUI when node stopped in cluster (PB1)
Posted by GitBox <gi...@apache.org>.
thenatog closed pull request #4496:
URL: https://github.com/apache/nifi/pull/4496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #4496: NIFI-7771: Infinite loop on WebUI when node stopped in cluster (PB1)
Posted by GitBox <gi...@apache.org>.
thenatog commented on pull request #4496:
URL: https://github.com/apache/nifi/pull/4496#issuecomment-729907790
I reviewed this with mtien-apache and verified that the authentication loop when using OIDC and a load balancer is now gone with this change.
+1 will merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org