[GitHub] [spark] HyukjinKwon commented on a change in pull request #33379: [SPARK-35810][SPARK-35807][PYTHON] Deprecate ps.broadcast API and the `num_files` argument

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #33379:
URL: https://github.com/apache/spark/pull/33379#discussion_r674501175



##########
File path: python/pyspark/pandas/namespace.py
##########
@@ -2822,6 +2823,8 @@ def broadcast(obj: DataFrame) -> DataFrame:
     """
     Marks a DataFrame as small enough for use in broadcast joins.
 
+    .. deprecated:: 3.2.0
+        Use :func:`DataFrame.spark.hint` instead.

Review comment:
       @itholic can you make a followup that adds a newline here? Sphinx build fails with:
   
   ```bash
   /.../spark/python/pyspark/pandas/namespace.py:docstring of pyspark.pandas.broadcast:6: WARNING: Explicit markup ends without a blank line; unexpected unindent.
   /.../spark/python/pyspark/pandas/namespace.py:docstring of pyspark.pandas.broadcast:7: WARNING: Unexpected section title.
   ```
   
   I don't know why it passes in GItHub Actions though.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org