You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/06 18:00:43 UTC

[GitHub] [spark] bersprockets commented on pull request #38923: [SPARK-41395][SQL] `InterpretedMutableProjection` should use `setDecimal` to set null values for high-precision decimals in an unsafe row

bersprockets commented on PR #38923:
URL: https://github.com/apache/spark/pull/38923#issuecomment-1339762795

   By the way, there's a similar-looking problem with type `CalendarInterval`:
   ```
   set spark.sql.codegen.wholeStage=false;
   set spark.sql.codegen.factoryMode=NO_CODEGEN;
   
   select first(col1), last(col2) from values
   (make_interval(0, 0, 0, 7, 0, 0, 0), make_interval(17, 0, 0, 2, 0, 0, 0))
   as data(col1, col2);
   
   +---------------+---------------+
   |first(col1)    |last(col2)     |
   +---------------+---------------+
   |16 years 2 days|16 years 2 days|
   +---------------+---------------+
   ```
   In this case, however, the bug doesn't appear to be in `InterpretedMutableProjection`, but in the way the unsafe buffer is initialized, so I will address it separately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org