You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "zhaorui2022 (via GitHub)" <gi...@apache.org> on 2023/09/20 23:07:49 UTC
[GitHub] [superset] zhaorui2022 opened a new issue, #25354: Chart with Groupby==null fails to render after upgrading to 3.0.0
zhaorui2022 opened a new issue, #25354:
URL: https://github.com/apache/superset/issues/25354
Hi, I have found a chart we have in production stops working after upgraded to 3.0.0. This is a Time-Series chart with `groupby==null` in the chart properties. The error seems related with [this line](https://github.com/apache/superset/blob/515452c7e2fb5da58bda788f4cf19e854e814852/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts#L181)
#### How to reproduce the bug
1. Create a chart or use any existing chart whose chart props has groupby set to null
2. Open the chart in 3.0.0
3. See error
### Expected results
Chart renders as in 2.0.0
### Actual results
Chart fails to render
#### Screenshots
chart props in 2.0.0
chart props in 3.0.0
### Environment
(please complete the following information):
- browser type and version: Chrome latest version
- superset version: `superset version` 3.0.0
- python version: `python --version` 3.9
- node.js version: `node -v` 20.6.0
- any feature flags active: We have Cross Filter disabled.
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Chart with Groupby==null fails to render after upgrading to 3.0.0 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #25354: Chart with Groupby==null fails to render after upgrading to 3.0.0
URL: https://github.com/apache/superset/issues/25354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaorui2022 commented on issue #25354: Chart with Groupby==null fails to render after upgrading to 3.0.0
Posted by "zhaorui2022 (via GitHub)" <gi...@apache.org>.
zhaorui2022 commented on issue #25354:
URL: https://github.com/apache/superset/issues/25354#issuecomment-1728587719
I made a [quick fix ](https://github.com/dropbox/incubator-superset-internal/commit/2e2b8d2e198b30b9e4633820f68cb2e18205e7ec)in our staging env which seems helping the chart to render, but not sure if there is any side effect by setting some default values. Would love to hear more thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Chart with Groupby==null fails to render after upgrading to 3.0.0 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25354:
URL: https://github.com/apache/superset/issues/25354#issuecomment-2447947512
Closing as stale (and since we don't support 3.0.0 any more)... but happy to reopen this if anyone is interested in contributing a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Chart with Groupby==null fails to render after upgrading to 3.0.0 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25354:
URL: https://github.com/apache/superset/issues/25354#issuecomment-1998458634
@zhaorui2022 would you still be interested in fixing/contributing to resolve this? I'm not sure if we _need_ to make the broader fix @michael-s-molina is talking about, or if your fix (and perhaps a test for it) would suffice. Seems like it would move the ball forward and let us close this issue as fixed. It's at risk of being closed as stale otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #25354: Chart with Groupby==null fails to render after upgrading to 3.0.0
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #25354:
URL: https://github.com/apache/superset/issues/25354#issuecomment-1732047157
Thanks for the issue @zhaorui2022. This is the problem of not having versioned schemas for the JSON fields 😞 I'm working on a more generic solution to ensure that all required fields, defined by Typescript, exist during runtime. I want to avoid the situation where the type definition does not accurately describe the data and the developers need to check for null values when the type definition clearly states that it shouldn't be the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org