You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/09/06 05:15:40 UTC
[GitHub] [doris] Kikyou1997 opened a new pull request, #12374: [feature-wip](nereids) Overwrite nullable method for Year function and Divid expression
Kikyou1997 opened a new pull request, #12374:
URL: https://github.com/apache/doris/pull/12374
# Proposed changes
Issue Number: noissue
## Problem summary
The nullability of these function should always be nullable, so just return true in the overwrite method.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on pull request #12374: [feature-wip](nereids) Overwrite nullable method for Year function and Divid expression
Posted by GitBox <gi...@apache.org>.
Kikyou1997 commented on PR #12374:
URL: https://github.com/apache/doris/pull/12374#issuecomment-1237668229
@morningman @jackwener @englefly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #12374: [feature-wip](nereids) Overwrite nullable method for Year function and Divid expression
Posted by GitBox <gi...@apache.org>.
englefly commented on code in PR #12374:
URL: https://github.com/apache/doris/pull/12374#discussion_r963808216
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/Year.java:
##########
@@ -53,7 +53,7 @@ public DataType getDataType() {
@Override
public boolean nullable() {
Review Comment:
`WeekOfYear` is the same. Could u update it in this pr.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Divide.java:
##########
@@ -50,4 +51,9 @@ public <R, C> R accept(ExpressionVisitor<R, C> visitor, C context) {
public AbstractDataType inputType() {
return NumericType.INSTANCE;
}
+
+ @Override
+ public boolean nullable() throws UnboundException {
+ return true;
Review Comment:
Could u add some comments to explain why it is nullable? I guess the reason is some string cannot be cast to date type. If this is true all date related functions are nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12374: [feature-wip](nereids) Overwrite nullable method for Year function and Divid expression
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12374:
URL: https://github.com/apache/doris/pull/12374#issuecomment-1238912523
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12374: [feature-wip](nereids) Overwrite nullable method for Year function and Divid expression
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12374:
URL: https://github.com/apache/doris/pull/12374#issuecomment-1238912490
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #12374: [feature](Nereids) let nullable of Year, weekOfYear and Divide be the same as implementation in BE
Posted by GitBox <gi...@apache.org>.
morrySnow merged PR #12374:
URL: https://github.com/apache/doris/pull/12374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #12374: [feature-wip](nereids) Overwrite nullable method for Year function and Divid expression
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #12374:
URL: https://github.com/apache/doris/pull/12374#discussion_r963923251
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Divide.java:
##########
@@ -50,4 +51,9 @@ public <R, C> R accept(ExpressionVisitor<R, C> visitor, C context) {
public AbstractDataType inputType() {
return NumericType.INSTANCE;
}
+
+ @Override
+ public boolean nullable() throws UnboundException {
+ return true;
Review Comment:
just because be implement like this, and be do not follow fe's plan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org