You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2022/07/01 15:12:31 UTC

[GitHub] [tomcat] ChristopherSchultz commented on a diff in pull request #531: Bugfix for 63080 - Support rfc7239 Forwarded header

ChristopherSchultz commented on code in PR #531:
URL: https://github.com/apache/tomcat/pull/531#discussion_r912048816


##########
java/org/apache/catalina/valves/RemoteIpValve.java:
##########
@@ -19,9 +19,7 @@
 import java.io.IOException;
 import java.net.InetAddress;
 import java.net.UnknownHostException;
-import java.util.Deque;
-import java.util.Enumeration;
-import java.util.LinkedList;
+import java.util.*;

Review Comment:
   Sorry, no. `import [something].*` is never a good idea. Please return the imports and add any explicit ones you need.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org