You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/08/05 15:55:41 UTC
[GitHub] [incubator-nuttx] phfbertoleti opened a new pull request #4289: Fixing BMP180 and INA219 in RP2040
phfbertoleti opened a new pull request #4289:
URL: https://github.com/apache/incubator-nuttx/pull/4289
## Summary
This commit does the following:
1- Add BMP180 and INA219 header files to rp2040_bringup.c (otherwise, both sensors couldn't be initalized)
2- Fix comment format at the end of rp2040_ina219.h file
## Impact
None (it just fixes things regarding to BMP180 and INA219 sensors usage in RP2040)
## Testing
It worked fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei edited a comment on pull request #4289: Fixing BMP180 and INA219 in RP2040
Posted by GitBox <gi...@apache.org>.
gustavonihei edited a comment on pull request #4289:
URL: https://github.com/apache/incubator-nuttx/pull/4289#issuecomment-893664715
Hi @phfbertoleti, try to squeeze the commit message into the 72 character limit from GitHub. Short commit messages also contribute to make `git log` cleaner.
Also, I suggest that you that a look at the commit history, the contributors usually follow the template `<subsystem>: <commit message>`.
Another personal suggestion not directly related to any NuttX standard: [this article](https://chris.beams.io/posts/git-commit/) from Chris Beams proposes 7 rules for writing good commit messages. It's worth checking out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #4289: Fixing BMP180 and INA219 in RP2040
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #4289:
URL: https://github.com/apache/incubator-nuttx/pull/4289#issuecomment-893697525
@phfbertoleti please rebase all commits to a single commit:
$ git pull
$ git rebase -i HEAD~2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] phfbertoleti commented on pull request #4289: Fixing BMP180 and INA219 in RP2040
Posted by GitBox <gi...@apache.org>.
phfbertoleti commented on pull request #4289:
URL: https://github.com/apache/incubator-nuttx/pull/4289#issuecomment-893688923
> Hi @phfbertoleti, try to squeeze the commit message into the 72 character limit from GitHub. Short commit messages also contribute to make `git log` cleaner.
> Also, I suggest that you that a look at the commit history, the contributors usually follow the template `<subsystem>: <commit message>`.
>
> Another personal suggestion not directly related to any NuttX standard: [this article](https://chris.beams.io/posts/git-commit/) from Chris Beams proposes 7 rules for writing good commit messages. It's worth checking out.
Thanks thor the suggestion. I just have fixed it. Please, could you check if this is fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] phfbertoleti edited a comment on pull request #4289: Fixing BMP180 and INA219 in RP2040
Posted by GitBox <gi...@apache.org>.
phfbertoleti edited a comment on pull request #4289:
URL: https://github.com/apache/incubator-nuttx/pull/4289#issuecomment-893688923
> Hi @phfbertoleti, try to squeeze the commit message into the 72 character limit from GitHub. Short commit messages also contribute to make `git log` cleaner.
> Also, I suggest that you that a look at the commit history, the contributors usually follow the template `<subsystem>: <commit message>`.
>
> Another personal suggestion not directly related to any NuttX standard: [this article](https://chris.beams.io/posts/git-commit/) from Chris Beams proposes 7 rules for writing good commit messages. It's worth checking out.
@gustavonihei, thanks for the suggestion. I just have fixed it. Please, could you check if this is fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #4289: Fixing BMP180 and INA219 in RP2040
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #4289:
URL: https://github.com/apache/incubator-nuttx/pull/4289#issuecomment-893755218
@phfbertoleti in the tab Commits here should appear only 1 commit, now it is showing 2 commits and 3 merges.
Did you create an "upstream" branch pointing to github.com/apache/incubator-nuttx master? If so you can do this way:
$ git checkout upstream
$ git pull
$ git checkout master
$ git rebase upstream
$ git rebase -i HEAD~2
In the editor message you keep the first commit and squash the second: just put "s" at beginning of the second line.
Use "git log" to confirm there is only 1 commit from you now and force a push:
$ git push -f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #4289: Fixing BMP180 and INA219 in RP2040
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #4289:
URL: https://github.com/apache/incubator-nuttx/pull/4289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on pull request #4289: Fixing BMP180 and INA219 in RP2040
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on pull request #4289:
URL: https://github.com/apache/incubator-nuttx/pull/4289#issuecomment-893664715
Hi @phfbertoleti, try to squeeze the commit message into the 72 character limit from GitHub. Short commit messages also contribute to make `git log` cleaner.
Also, I suggest that you that a look at the commit history, the contributors usually follow the template `<subsystem>: <commit message>`.
Another personal suggestion not directly related to any NuttX standard: [this article](https://chris.beams.io/posts/git-commit/) from Chris Beams proposes 7 rules for good commit messages. It's worth checking out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei edited a comment on pull request #4289: Fixing BMP180 and INA219 in RP2040
Posted by GitBox <gi...@apache.org>.
gustavonihei edited a comment on pull request #4289:
URL: https://github.com/apache/incubator-nuttx/pull/4289#issuecomment-893696996
> > Hi @phfbertoleti, try to squeeze the commit message into the 72 character limit from GitHub. Short commit messages also contribute to make `git log` cleaner.
> > Also, I suggest that you that a look at the commit history, the contributors usually follow the template `<subsystem>: <commit message>`.
> > Another personal suggestion not directly related to any NuttX standard: [this article](https://chris.beams.io/posts/git-commit/) from Chris Beams proposes 7 rules for writing good commit messages. It's worth checking out.
>
> @gustavonihei, thanks for the suggestion. I just have fixed it. Please, could you check if this is fine?
The new message looks better, but now your branch contains duplicated commits.
Commits 40c58427de2820995f404f58ecde9397d5017a3b and 75b0b3e96943716b27e1e4b7685b10ee36ac9ba3 should be removed.
You may do this with `git rebase -i master` and drop them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on pull request #4289: Fixing BMP180 and INA219 in RP2040
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on pull request #4289:
URL: https://github.com/apache/incubator-nuttx/pull/4289#issuecomment-893696996
> > Hi @phfbertoleti, try to squeeze the commit message into the 72 character limit from GitHub. Short commit messages also contribute to make `git log` cleaner.
> > Also, I suggest that you that a look at the commit history, the contributors usually follow the template `<subsystem>: <commit message>`.
> > Another personal suggestion not directly related to any NuttX standard: [this article](https://chris.beams.io/posts/git-commit/) from Chris Beams proposes 7 rules for writing good commit messages. It's worth checking out.
>
> @gustavonihei, thanks for the suggestion. I just have fixed it. Please, could you check if this is fine?
The new message looks better, but now your branch contains duplicated commits.
Commits 40c58427de2820995f404f58ecde9397d5017a3b and 75b0b3e96943716b27e1e4b7685b10ee36ac9ba3 should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org