[jira] [Created] (OAK-4992) Use the role name as prefix for directory used by SegmentNodeStoreFactory

["Chetan Mehrotra (JIRA)" <ji...@apache.org>]

Chetan Mehrotra created OAK-4992:
------------------------------------

             Summary: Use the role name as prefix for directory used by SegmentNodeStoreFactory
                 Key: OAK-4992
                 URL: https://issues.apache.org/jira/browse/OAK-4992
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: segment-tar, segmentmk
            Reporter: Chetan Mehrotra
            Assignee: Chetan Mehrotra
            Priority: Minor
             Fix For: 1.6


Currently SegmentNodeStoreFactory uses a directory named {{segmentstore}} under repository home to store the segment files. To allow easier setup where multiple NodeStore instance do not overstep on each other this name should be prefixed with {{role}} 

Note that code tries to do the same currently with logic below but it ends up always creating {{segmentstore}} folder under repository home. As a fix {{role}} should be used in {{getDirectory}} method

{code}
    private File getBaseDirectory() {
        String directory = property(DIRECTORY);

        if (directory != null) {
            return new File(directory);
        }

        if (role == null) {
            return new File("tarmk");
        } else {
            return new File("tarmk-" + role);
        }
    }

    private File getDirectory() {
        return new File(getBaseDirectory(), "segmentstore");
    }
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)